Skip to content

Update NCCL Test Templates and Introduce Kubernetes-Specific Strategies #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
srinivas212 merged 5 commits into from
Sep 5, 2024
Merged

Update NCCL Test Templates and Introduce Kubernetes-Specific Strategies #186

srinivas212 merged 5 commits into from
Sep 5, 2024

Conversation

@TaekyungHeo
Copy link
Member

@TaekyungHeo TaekyungHeo commented Sep 3, 2024 •
edited
Loading

Summary

  • Add NCCL test templates.
  • Store output log files upon job completion.

Test Plan

  1. CI passes.
  2. https://github.com/Mellanox/cloudaix/pull/39#issue-2503854408

@TaekyungHeo TaekyungHeo added Oct24 Oct'24 release feature feature labels Sep 3, 2024
TaekyungHeo
TaekyungHeo commented Sep 3, 2024
View reviewed changes
@TaekyungHeo TaekyungHeo changed the title Update NCCL Test Templates and Introduce Kubernetes-Specific Strategies (No Shared Dir / No Mixin / Sep 3rd) Update NCCL Test Templates and Introduce Kubernetes-Specific Strategies Sep 3, 2024
@TaekyungHeo TaekyungHeo marked this pull request as ready for review September 3, 2024 22:36
amaslenn
amaslenn previously approved these changes Sep 4, 2024
View reviewed changes
srivatsankrishnan
srivatsankrishnan reviewed Sep 5, 2024
View reviewed changes
@TaekyungHeo @srivatsankrishnan
Read docker_image_url from cmd_args
2b786b5 
Co-authored-by: Srivatsan Krishnan <srivatsank@nvidia.com>
srivatsankrishnan
srivatsankrishnan approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@srivatsankrishnan srivatsankrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@srinivas212 srinivas212 merged commit 15472db into NVIDIA:main Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srivatsankrishnan srivatsankrishnan srivatsankrishnan approved these changes

@srinivas212 srinivas212 srinivas212 approved these changes

@amaslenn amaslenn amaslenn left review comments

@artemry-nv artemry-nv Awaiting requested review from artemry-nv

Assignees

No one assigned

Labels

feature Oct24 Oct'24 release feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TaekyungHeo @amaslenn @srivatsankrishnan @srinivas212