Fix bug in violating Kubernetes naming rules #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaekyungHeo
requested review from
amaslenn,
artemry-nv,
srinivas212 and
srivatsankrishnan
amaslenn
previously approved these changes
Oct 8, 2024
amaslenn
reviewed
Oct 8, 2024
src/cloudai/schema/test_template/nccl_test/kubernetes_json_gen_strategy.py
Show resolved
Hide resolved
TaekyungHeo
dismissed stale reviews from srivatsankrishnan and amaslenn
via
5d4870f
amaslenn
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Using the section name as the job name in Kubernetes can lead to a bug due to noncompliance with Kubernetes naming rules. Resource names must be lowercase, can only include alphanumeric characters, hyphens, and periods, and must start and end with an alphanumeric character. This pull request fixes the bug.
Test Plan