Refactor SlurmCommandGenStrategy (_write_sbatch_script) #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaekyungHeo
changed the title
TaekyungHeo
requested review from
amaslenn,
artemry-nv,
srinivas212 and
srivatsankrishnan
TaekyungHeo
added
enhancement
amaslenn
reviewed
Oct 14, 2024
src/cloudai/schema/test_template/jax_toolbox/slurm_command_gen_strategy.py
Show resolved
Hide resolved
src/cloudai/schema/test_template/jax_toolbox/slurm_command_gen_strategy.py
Show resolved
Hide resolved
src/cloudai/schema/test_template/chakra_replay/slurm_command_gen_strategy.py
Outdated
Show resolved
Hide resolved
amaslenn
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove the duplicated code in the *SlurmCommandGenStrategy classes.
Test Plan