Skip to content

Improve verify modes #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TaekyungHeo merged 3 commits into from
Oct 14, 2024
Merged

Improve verify modes #262

TaekyungHeo merged 3 commits into from
Oct 14, 2024

Conversation

@amaslenn
Copy link
Contributor

@amaslenn amaslenn commented Oct 14, 2024 •
edited
Loading

Summary

  1. Verify all configs, not just till first failure.
  2. Improve errors reporting.

Test Plan

  1. CI.
  2. Manual run for different modes and check output.

Additional Notes

Example output:

cloudai verify-systems conf/common/system
[INFO] Verifying conf/common/system/standalone_system.toml...
[INFO] Verifying conf/common/system/example_slurm_cluster.toml...
[ERROR] Failed to parse system definition: conf/common/system/example_slurm_cluster.toml
[ERROR] Field 'install_path': Field required
[INFO] Verifying conf/common/system/kubernetes_cluster.toml...
[ERROR] Failed to parse system definition: conf/common/system/kubernetes_cluster.toml
[ERROR] Field 'install_path': Field required
[ERROR] 2 out of 3 system configurations have issues.

TaekyungHeo
TaekyungHeo reviewed Oct 14, 2024
View reviewed changes
@amaslenn amaslenn added the enhancement New feature or request label Oct 14, 2024
@TaekyungHeo TaekyungHeo added Oct24 Oct'24 release feature enhancement New feature or request and removed enhancement New feature or request labels Oct 14, 2024
srivatsankrishnan
srivatsankrishnan approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@srivatsankrishnan srivatsankrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Clarified the PR during the call.

@TaekyungHeo TaekyungHeo merged commit 0af4cd9 into main Oct 14, 2024
@TaekyungHeo TaekyungHeo deleted the am/improve-verify branch October 14, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TaekyungHeo TaekyungHeo TaekyungHeo left review comments

@srivatsankrishnan srivatsankrishnan srivatsankrishnan approved these changes

@srinivas212 srinivas212 Awaiting requested review from srinivas212

Assignees

No one assigned

Labels

enhancement New feature or request Oct24 Oct'24 release feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@amaslenn @TaekyungHeo @srivatsankrishnan