Support installing PythonExecutable in a subpath #404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaekyungHeo
force-pushed
the
pytorch-exec-subpath
branch
4 times, most recently
from
faa3ff5 to
9b1ab24
Compare
TaekyungHeo
force-pushed
the
pytorch-exec-subpath
branch
from
9b1ab24 to
69963a0
Compare
TaekyungHeo
changed the title
TaekyungHeo
requested review from
amaslenn,
srinivas212 and
srivatsankrishnan
as code owners
amaslenn
reviewed
Mar 10, 2025
Member
Author
|
@amaslenn, thanks for the comments. I have updated the code accordingly. I tested it on an internal server and confirmed that the target binaries are installed. Please see if the updated code makes sense. |
amaslenn
reviewed
Mar 10, 2025
amaslenn
reviewed
Mar 10, 2025
TaekyungHeo
commented
Mar 10, 2025
amaslenn
reviewed
Mar 12, 2025
amaslenn
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support installing PythonExecutable in a subpath
Test Plan