-
Notifications
You must be signed in to change notification settings - Fork 42
Nemo2.0 Lora + Null tokenizer #430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaekyungHeo
previously approved these changes
Mar 26, 2025
amaslenn
reviewed
Mar 26, 2025
amaslenn
previously approved these changes
Mar 26, 2025
amaslenn
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces SFT/LoRA support in CloudAI Nemo2.0. The main features for performance tracking are the null tokenizer for benchmarking tasks. The entry point script (cloudai_nemorun.py) has the necessary modification to add Null tokenizer, hf_tokenizer. It also defines a new environment variable called CLOUDAI_NEMO_TASK which can take the values of pretrain or finetune which can be defined in the toml file.
We will hijack the cmd_args.task variable to set the new environment variable. This variable is used to control the flow to choose between pretrain and finetune.
This is duplicate of this PR I accidently deleted some tests and recommitted and the
copyright yearunit tests wasn't letting to me use the original dates.Dependencies
Test Plan
CI/CD
Dry Run
Real System
Results (redacted all numbers). PLease ping me on slack for logs
Additional Notes
Has the changes of this PR 419 but without the
copyright yearmess I created due to acceidental deletion of some test files.