Skip to content

Update docker_image_url separator from colon to hash #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
srivatsankrishnan merged 1 commit into from
Aug 6, 2025
Merged

Update docker_image_url separator from colon to hash #621

srivatsankrishnan merged 1 commit into from
Aug 6, 2025

Conversation

@TaekyungHeo
Copy link
Member

@TaekyungHeo TaekyungHeo commented Aug 6, 2025 •
edited
Loading

Summary

Update docker_image_url separator from colon to hash

Test Plan

  1. CI passes
  2. Run on CW
$ cloudai install --system-config ../cloudaix/conf/common/system/cw.toml --tests-dir conf/common/test
[INFO] System Name: Coreweave
[INFO] Scheduler: slurm
[INFO] Not all components are ready
[INFO] Going to install 6 item(s)
...
[INFO] CloudAI is successfully installed into '...'.

@TaekyungHeo TaekyungHeo added the bug Something isn't working label Aug 6, 2025
@TaekyungHeo TaekyungHeo marked this pull request as ready for review August 6, 2025 13:37
srivatsankrishnan
srivatsankrishnan approved these changes Aug 6, 2025
View reviewed changes
Copy link
Contributor

@srivatsankrishnan srivatsankrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# seems to be the recommended by enroot/pyxis team as confirmed by Taekyung and QA testing by Ofir.

LGTM.

@srivatsankrishnan srivatsankrishnan merged commit a49d24f into NVIDIA:main Aug 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srivatsankrishnan srivatsankrishnan srivatsankrishnan approved these changes

@amaslenn amaslenn Awaiting requested review from amaslenn amaslenn is a code owner

@srinivas212 srinivas212 Awaiting requested review from srinivas212

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TaekyungHeo @srivatsankrishnan