Skip to content

Conversation

@amaslenn
Copy link
Contributor

@amaslenn amaslenn commented Sep 9, 2025

Summary

Provide a concise summary of the changes introduced by this pull request. Detail the purpose and scope of the changes, referencing any relevant issues or discussions. Explain how these changes address the problem or improve the project.

Fixes internal bug.

Test Plan

  1. CI (extended).
  2. Run dry-run using configs from the bug:
...
[INFO] System Name: example-cluster
[INFO] Scheduler: slurm
[INFO] Test Scenario Name: ncclint-test
[INFO] Checking if workloads components are installed.
[INFO] Test Scenario: ncclint-test

Section Name: Tests.all_reduce
  Test Name: ncclint_base_test
  Description: NCCL internal plugin base test configuration
  No dependencies
Section Name: Tests.reduce_scatter
  Test Name: ncclint_base_test
  Description: NCCL internal plugin base test configuration
  Start Post Comp: Tests.all_reduce
Section Name: Tests.all_gather
  Test Name: ncclint_base_test
  Description: NCCL internal plugin base test configuration
  Start Post Comp: Tests.reduce_scatter
[INFO] Initializing Runner [DRY-RUN] mode
[INFO] Creating SlurmRunner
[ERROR] Dependencies are not supported for DSE jobs, all cases run consecutively. Please remove dependencies and re-run.

Additional Notes

@amaslenn amaslenn added the bug Something isn't working label Sep 9, 2025
@amaslenn amaslenn marked this pull request as ready for review September 9, 2025 12:03
@amaslenn amaslenn merged commit c2f709f into main Sep 9, 2025
2 checks passed
@amaslenn amaslenn deleted the am/bug-4545846 branch September 9, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants