Fix base_tr fixture dependency

[podkidyshev]

Summary

Implemets #780

Makes sure base_tr fixture doesn't use slurm_system as a dependency

Test Plan

Unit-tests are sufficient

Additional Notes

[greptile-apps]

Greptile Summary

Removes the slurm_system dependency from the base_tr test fixture. The fixture now uses tmp_path directly instead of accessing the output path through slurm_system. This makes the fixture more flexible and system-agnostic, as base_tr is a general-purpose test fixture that should work with any system type (Slurm, Kubernetes, RunAI, Standalone) without requiring Slurm-specific configuration.

Changes

• Changed base_tr fixture parameter from slurm_system: SlurmSystem to tmp_path: Path
• Updated output_path construction from slurm_system.output_path / "tr-name" to tmp_path / "output" / "tr-name"

Confidence Score: 5/5

• This PR is safe to merge with no risks
• The change is a simple, well-contained refactoring that removes an unnecessary dependency. The fixture now uses tmp_path directly, which is cleaner and makes the fixture system-agnostic. All usage patterns remain compatible since tests only access base_tr.output_path, which continues to work correctly.
• No files require special attention

Important Files Changed

Filename	Overview
tests/conftest.py	Removed unnecessary slurm_system dependency from base_tr fixture, making it system-agnostic by using tmp_path instead

_{Last reviewed commit: 747d345}

[greptile-apps]

_{1 file reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

---

📝 Walkthrough

Walkthrough

The base_tr pytest fixture in tests/conftest.py was refactored to accept a Path parameter (tmp_path) instead of a SlurmSystem parameter. The fixture now derives the TestRun's output path from the provided temporary path rather than from the SlurmSystem instance, decoupling the fixture from SlurmSystem dependency.

Changes

Cohort / File(s)	Summary
Pytest Fixture Refactoring tests/conftest.py	Updated base_tr fixture signature to accept tmp_path: Path instead of slurm_system: SlurmSystem, with TestRun output_path now derived from tmp_path rather than SlurmSystem.output_path.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐰 A fixture once bound to the Slurm's heavy chain,
Now dances through tmp_path, light and plain,
No system required, just paths it inspired,
My tests hop with freedom gained! 🐇✨

🚥 Pre-merge checks | ✅ 2

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: removing the slurm_system dependency from the base_tr fixture.
Description check	✅ Passed	The description is related to the changeset, referencing issue #780 and the specific fixture dependency change being implemented.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch ipod/780-base-tr-fixture-deps

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}