Skip to content

Allow profiling ranks in string format with comma as separator #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
podkidyshev merged 2 commits into from
Apr 1, 2026
Merged

Allow profiling ranks in string format with comma as separator #855

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89287e8
Allow profiling ranks in string format with comma as separator
juntaowww Mar 31, 2026
8054958
Add a test for string format of profiling ranks
juntaowww Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/cloudai/workloads/megatron_bridge/megatron_bridge.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,10 @@ class MegatronBridgeCmdArgs(CmdArgs):
profiling_stop_step: Optional[int] = Field(default=None)
record_memory_history: Optional[bool] = Field(default=None)
profiling_gpu_metrics: Optional[bool] = Field(default=None)
profiling_ranks: Optional[Union[int, List[int]]] = Field(default=None)
profiling_ranks: Optional[Union[int, str, List[int]]] = Field(
default=None,
description="Rank ID, comma-separated rank IDs as a string (e.g. '0,4,8'), or list of rank IDs.",
)
nsys_trace: Optional[Union[str, List[str]]] = Field(
default=None,
description="Comma-separated nsys trace events (e.g. cuda,nvtx).",
Expand Down
14 changes: 14 additions & 0 deletions tests/workloads/megatron_bridge/test_command_gen_strategy_slurm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,3 +439,17 @@ def test_parse_srun_args_boolean_flags(self) -> None:
"--exclusive --reservation my_reserv --overcommit"
)
assert result == ["exclusive", "reservation=my_reserv", "overcommit"]

def test_profiling_ranks_string_format(
self,
configured_slurm_system: SlurmSystem,
make_test_run: Callable[..., TestRun],
) -> None:
tr = make_test_run(
cmd_args_overrides={"profiling_ranks": "0,1,2,3", "enable_nsys": True},
output_subdir="out_prof_str",
)
assert not tr.is_dse_job
cmd_gen = MegatronBridgeSlurmCommandGenStrategy(configured_slurm_system, tr)
wrapper_content = self._wrapper_content(cmd_gen)
assert "--profiling_ranks 0,1,2,3" in wrapper_content
Loading