Skip to content

fix secret scan false positive#883

Merged
podkidyshev merged 1 commit into
mainfrom
ipod/fix-secret-scan
Apr 23, 2026
Merged

fix secret scan false positive#883
podkidyshev merged 1 commit into
mainfrom
ipod/fix-secret-scan

Conversation

@podkidyshev
Copy link
Copy Markdown
Contributor

@podkidyshev podkidyshev commented Apr 23, 2026

Summary

Fix internal secret scanner

Test Plan

  • Automated CI
  • Run internal scanner - no issues found anymore

Additional Notes

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 23, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 81d08199-dad2-4ec1-9ff5-fecfa58024c0

📥 Commits

Reviewing files that changed from the base of the PR and between cda8f9d and c9ce0cb.

📒 Files selected for processing (1)
  • tests/test_base_installer.py

📝 Walkthrough

Walkthrough

The test_docker_cache_filename parametrized test cases were updated by removing Docker URL→cache-filename mappings for gitlab.com and registry.example.com inputs and replacing them with new mappings for ditdab.com and registry.invalid inputs. Test assertions now expect different sanitized cache filenames for these registry/domain patterns.

Changes

Cohort / File(s) Summary
Test Case Updates
tests/test_base_installer.py
Updated Docker URL→cache-filename test mappings, replacing gitlab.com and registry.example.com test cases with ditdab.com and registry.invalid test cases in parametrized test_docker_cache_filename.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Hops with joy through test files bright,
New domains dance in parametrized light,
Cache filenames transformed with care,
ditdab and invalid now here,
Testing data refreshed, bugs take flight! 🎉

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title describes fixing a secret scan false positive, which aligns with the changeset that modifies test case URLs to remove gitlab.com and registry.example.com patterns.
Description check ✅ Passed The description indicates the PR fixes an internal secret scanner issue, which relates to the test URL modifications designed to prevent false positives.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ipod/fix-secret-scan

Comment @coderabbitai help to get the list of available commands and usage tips.

@podkidyshev podkidyshev self-assigned this Apr 23, 2026
@podkidyshev podkidyshev added the bug Something isn't working label Apr 23, 2026
@podkidyshev podkidyshev marked this pull request as ready for review April 23, 2026 11:11
@podkidyshev podkidyshev merged commit bbd1628 into main Apr 23, 2026
5 checks passed
@podkidyshev podkidyshev deleted the ipod/fix-secret-scan branch April 23, 2026 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants