Fixing compile errors when compiling with clang++#29
Merged
iwald-nvidia merged 1 commit intoNVIDIA:mainfrom Mar 26, 2026
Merged
Fixing compile errors when compiling with clang++#29iwald-nvidia merged 1 commit intoNVIDIA:mainfrom
iwald-nvidia merged 1 commit intoNVIDIA:mainfrom
Conversation
Collaborator
|
Hey - sorry this took so long, for some reason i didn't get a notifcation on that. Happy to merge this after CI runs through (assuming it will :-) ); but just a note: clang isn't in the CI yet; if you want to make sure that this gets tested going forward i'd be happy to take a PR on an updated CI script as well. |
Collaborator
Author
|
No worries at all! :) It looks like the CI failed due to this change: |
Collaborator
|
BTW I think you can also manually start the CI in your own fork by clicking on "actions" tab. I always use this myself to check on the windows build - i develop under linux, then do a CI run to see if that still builds on windows before creating PR. |
Signed-off-by: Daniela Hasenbring <dhasenbring@nvidia.com>
7b9b38c to
c68a66d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes compile errors when compiling cuBQL with clang++.
Original error messages were: