Skip to content

More cmake improvements and compilation fix to handle cudf nightly update#85

Merged
rapids-bot[bot] merged 5 commits intoNVIDIA:mainfrom
9prady9:minor_cmake_changes
Mar 11, 2026
Merged

More cmake improvements and compilation fix to handle cudf nightly update#85
rapids-bot[bot] merged 5 commits intoNVIDIA:mainfrom
9prady9:minor_cmake_changes

Conversation

@9prady9
Copy link
Copy Markdown
Contributor

@9prady9 9prady9 commented Mar 11, 2026

  • Make cmake option prefix (CUCASCADE_) consistent for all options
  • Make CXX standard part of public interface and CUDA part of private interface.
  • Fix static_assert for RMM 26.x: handle removed polyfill namespace for newer versions
  • Fixed formatting.

9prady9 added 4 commits March 11, 2026 13:29
rmm::detail::polyfill::async_resource_with was removed in RMM 26.x.
Use cuda::mr::resource_with directly for RMM >= 26, and keep the
polyfill path for older versions.
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Mar 11, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@mbrobbel
Copy link
Copy Markdown
Member

/ok to test 02ec97c

Comment thread test/CMakeLists.txt Outdated
Comment thread CMakeLists.txt Outdated
Comment thread CMakeLists.txt
@mbrobbel
Copy link
Copy Markdown
Member

/merge

@rapids-bot rapids-bot Bot merged commit 1c5a3c7 into NVIDIA:main Mar 11, 2026
2 checks passed
@9prady9 9prady9 deleted the minor_cmake_changes branch March 11, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants