Refactor window storage #627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PointKernel
added
In Progress
PointKernel
added
helps: rapids
sleeepyjack
reviewed
Nov 1, 2024
Collaborator
sleeepyjack
left a comment
sleeepyjack
left a comment
There was a problem hiding this comment.
Wow, so many changes! I went over most of it but at some point during reading my brain started to come up with every possible pronunciation of the word "bucket". 😵
Co-authored-by: Daniel Jünger <djuenger@nvidia.com>
sleeepyjack
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #621
Based on the offline discussions, this PR replaces the
windowlogic withbucketand adds new overloads ofmake_bucket_extentso OA no longer relies on theContainertype to determine the bucket extent.