Update cuco implementations to use cuda::std utilities when appropriate #708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PointKernel
added
the
type: improvement
bdice
approved these changes
May 1, 2025
Contributor
bdice
left a comment
bdice
left a comment
There was a problem hiding this comment.
Generally LGTM -- ideally we would use cuda::std::tuple in the places where thrust::tuple is being used.
| #include <cuco/detail/bitwise_compare.cuh> | ||
| #include <cuco/detail/pair/traits.hpp> | ||
|
|
||
| #include <thrust/tuple.h> |
Contributor
There was a problem hiding this comment.
I think cuda::std::tuple should be preferred here? Please try it. It's also okay to defer this to another PR.
Member
Author
There was a problem hiding this comment.
Right, the issue is from the outdated CCCL version, where zip_iterator is incompatible with cuda::std::tuple: https://godbolt.org/z/jnKafGPf4. Currently, cuco is still pulling in rapids-cmake branch-25.02, which brings in CCCL 2.7. Once we update to a newer version of rapids-cmake, CCCL will be upgraded accordingly, and we’ll be able to fully replace thrust::tuple with cuda::std::tuple in cuco.
sleeepyjack
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates cuco implementations to use
cuda::stdutilities in place ofstdin device code and to replacethrustutilities wherever possible, as they are being deprecated in CCCL.