[JAX] make trimul cache name/keys similar to their torch counterpart #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsadasivan
reviewed
Sep 16, 2025
| dtypes = [ | ||
| str(t.dtype if t.dtype != jnp.bfloat16 else jnp.dtype(jnp.float16)) | ||
| for t in [x1, x2, w1, w2, b1, b2, mask] | ||
| "torch." + str(t.dtype if t.dtype != jnp.bfloat16 else jnp.dtype(jnp.float16)) |
Collaborator
There was a problem hiding this comment.
We should remove the 'torch' sometime everywhere, I'd change it everywhere when we have more time.
For now, maybe good to leave this as comment:
We currently perform tuning in torch. Leaving the same annotation here as a lazy implementation.
hsadasivan
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make JAX implementation of trimul able to load the same cache files used in the counterpart pytorch code.