Improve speed of init functions in cybind-generated bindings #1009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
kkraus14
approved these changes
Sep 23, 2025
This comment has been minimized.
This comment has been minimized.
|
leofang
reviewed
Sep 25, 2025
Comment on lines
98
to
99
| if __py_nvjitlink_init: | ||
| return 0 |
There was a problem hiding this comment.
btw internally we dropped these two lines
|
For posterity, this PR was backported as part of #1044. |
leofang
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is applying the same trick in #894 to the cybind-generated bindings.
Essentially, by inlining the boolean check in every call, we can avoid the much more expensive call through a C function pointer on every single API call.