Skip to content

Improve speed of init functions in cybind-generated bindings #1009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2025
Merged

Improve speed of init functions in cybind-generated bindings #1009

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions cuda_bindings/cuda/bindings/_internal/cufile_linux.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,10 +108,8 @@ cdef void* load_library() except* with gil:
return <void*>handle


cdef int _check_or_init_cufile() except -1 nogil:
cdef int __check_or_init_cufile() except -1 nogil:
global __py_cufile_init
if __py_cufile_init:
return 0

cdef void* handle = NULL

Expand Down Expand Up @@ -422,6 +420,13 @@ cdef int _check_or_init_cufile() except -1 nogil:
return 0


cdef inline int _check_or_init_cufile() except -1 nogil:
if __py_cufile_init:
return 0

return __check_or_init_cufile()


cdef dict func_ptrs = None


Expand Down
10 changes: 7 additions & 3 deletions cuda_bindings/cuda/bindings/_internal/nvjitlink_linux.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,8 @@ cdef void* load_library() except* with gil:
return <void*>handle


cdef int _check_or_init_nvjitlink() except -1 nogil:
cdef int __check_or_init_nvjitlink() except -1 nogil:
global __py_nvjitlink_init
if __py_nvjitlink_init:
return 0

cdef void* handle = NULL

Expand Down Expand Up @@ -188,6 +186,12 @@ cdef int _check_or_init_nvjitlink() except -1 nogil:
return 0


cdef inline int _check_or_init_nvjitlink() except -1 nogil:
if __py_nvjitlink_init:
return 0

return __check_or_init_nvjitlink()

cdef dict func_ptrs = None


Expand Down
9 changes: 8 additions & 1 deletion cuda_bindings/cuda/bindings/_internal/nvjitlink_windows.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ cdef void* __nvJitLinkGetInfoLog = NULL
cdef void* __nvJitLinkVersion = NULL


cdef int _check_or_init_nvjitlink() except -1 nogil:
cdef int __check_or_init_nvjitlink() except -1 nogil:
global __py_nvjitlink_init
if __py_nvjitlink_init:
return 0
Comment on lines 98 to 99
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw internally we dropped these two lines

Expand Down Expand Up @@ -149,6 +149,13 @@ cdef int _check_or_init_nvjitlink() except -1 nogil:
return 0


cdef inline int _check_or_init_nvjitlink() except -1 nogil:
if __py_nvjitlink_init:
return 0

return __check_or_init_nvjitlink()


cdef dict func_ptrs = None


Expand Down
11 changes: 8 additions & 3 deletions cuda_bindings/cuda/bindings/_internal/nvvm_linux.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,8 @@ cdef void* load_library() except* with gil:
return <void*>handle


cdef int _check_or_init_nvvm() except -1 nogil:
cdef int __check_or_init_nvvm() except -1 nogil:
global __py_nvvm_init
if __py_nvvm_init:
return 0

cdef void* handle = NULL

Expand Down Expand Up @@ -180,6 +178,13 @@ cdef int _check_or_init_nvvm() except -1 nogil:
return 0


cdef inline int _check_or_init_nvvm() except -1 nogil:
if __py_nvvm_init:
return 0

return __check_or_init_nvvm()


cdef dict func_ptrs = None


Expand Down
11 changes: 8 additions & 3 deletions cuda_bindings/cuda/bindings/_internal/nvvm_windows.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,8 @@ cdef void* __nvvmGetProgramLogSize = NULL
cdef void* __nvvmGetProgramLog = NULL


cdef int _check_or_init_nvvm() except -1 nogil:
cdef int __check_or_init_nvvm() except -1 nogil:
global __py_nvvm_init
if __py_nvvm_init:
return 0

with gil, __symbol_lock:
# Load library
Expand Down Expand Up @@ -145,6 +143,13 @@ cdef int _check_or_init_nvvm() except -1 nogil:
return 0


cdef inline int _check_or_init_nvvm() except -1 nogil:
if __py_nvvm_init:
return 0

return __check_or_init_nvvm()


cdef dict func_ptrs = None


Expand Down
Loading