Skip to content

Avoid adding __dict__ to every child class #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cpcloud merged 4 commits into from
Oct 8, 2025
Merged

Avoid adding __dict__ to every child class #1104

cpcloud merged 4 commits into from
Oct 8, 2025

Conversation

@leofang
Copy link
Member

@leofang leofang commented Oct 8, 2025

Description

closes

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Oct 8, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

cpcloud
cpcloud previously approved these changes Oct 8, 2025
View reviewed changes
@leofang
Copy link
Member Author

leofang commented Oct 8, 2025

/ok to test f3c9d0f

@github-actions

This comment has been minimized.

Sign in to view
@leofang leofang self-assigned this Oct 8, 2025
@leofang leofang added bug Something isn't working P0 High priority - Must do! cuda.core Everything related to the cuda.core module labels Oct 8, 2025
@leofang leofang added this to the cuda.core beta 7 milestone Oct 8, 2025
@leofang leofang mentioned this pull request Oct 8, 2025
Closed
2 tasks
@leofang leofang marked this pull request as ready for review October 8, 2025 15:03
@leofang
Copy link
Member Author

leofang commented Oct 8, 2025

/ok to test 5d64b51

cpcloud
cpcloud requested changes Oct 8, 2025
View reviewed changes
@leofang
Copy link
Member Author

leofang commented Oct 8, 2025

/ok to test 46d1e34

@leofang
Copy link
Member Author

leofang commented Oct 8, 2025

/ok to test 43953f9

@leofang
Copy link
Member Author

leofang commented Oct 8, 2025

CI is green, finally!

@cpcloud cpcloud mentioned this pull request Oct 8, 2025
Merged
@leofang leofang mentioned this pull request Oct 8, 2025
Closed
@cpcloud cpcloud merged commit 4754292 into NVIDIA:main Oct 8, 2025
71 checks passed
@leofang leofang deleted the remove_dict branch October 8, 2025 17:41
@github-actions
Copy link

github-actions bot commented Oct 8, 2025

Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpcloud cpcloud cpcloud approved these changes

Assignees

@leofang leofang

Labels

bug Something isn't working cuda.core Everything related to the cuda.core module P0 High priority - Must do!

Projects

None yet

Milestone

cuda.core beta 7

Development

Successfully merging this pull request may close these issues.

2 participants

@leofang @cpcloud