Skip to content

Conversation

@mdboom
Copy link
Contributor

@mdboom mdboom commented Oct 17, 2025

This enables ccache on our non-Windows builds. This should make builds significantly faster.

(I'm going to run CI twice here to confirm it works as advertised.)

@mdboom mdboom requested a review from cpcloud October 17, 2025 15:16
@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Oct 17, 2025

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@mdboom
Copy link
Contributor Author

mdboom commented Oct 17, 2025

/ok to test

cpcloud
cpcloud previously approved these changes Oct 17, 2025
@cpcloud
Copy link
Contributor

cpcloud commented Oct 17, 2025

Any reason not to use https://github.com/mozilla/sccache (and https://github.com/mozilla/sccache-action) which seems to support windows?

@mdboom
Copy link
Contributor Author

mdboom commented Oct 17, 2025

/ok to test

@mdboom
Copy link
Contributor Author

mdboom commented Oct 17, 2025

Any reason not to use https://github.com/mozilla/sccache (and https://github.com/mozilla/sccache-action) which seems to support windows?

Nah, I just wasn't aware of it. It used to require a server component, but it looks like it defaults to local storage. I'll file an alternative PR for that and we can compare.

@mdboom
Copy link
Contributor Author

mdboom commented Oct 17, 2025

Also, it looks like the workflow is getting stuck here. I wonder if it's because this PR modifies a workflow and there is an additional approval required for the bot (or something)?

@leofang
Copy link
Member

leofang commented Oct 17, 2025

This action is not yet approved by our admin, need to reach out to them first:
https://github.com/NVIDIA/cuda-python/actions/runs/18597054102

@mdboom
Copy link
Contributor Author

mdboom commented Oct 17, 2025

This action is not yet approved by our admin, need to reach out to them first: https://github.com/NVIDIA/cuda-python/actions/runs/18597054102

Thanks. That explains it. Let's not reach out just yet -- the alternative of using sccache that @cpcloud suggested seems to be already approved, and if it works, we might as well go with it: #1156

@mdboom
Copy link
Contributor Author

mdboom commented Oct 20, 2025

/ok to test

@mdboom
Copy link
Contributor Author

mdboom commented Oct 20, 2025

/ok to test

@mdboom mdboom closed this Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants