-
Notifications
You must be signed in to change notification settings - Fork 217
[chore] Enable ccache in builds #1154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
|
Any reason not to use https://github.com/mozilla/sccache (and https://github.com/mozilla/sccache-action) which seems to support windows? |
|
/ok to test |
Nah, I just wasn't aware of it. It used to require a server component, but it looks like it defaults to local storage. I'll file an alternative PR for that and we can compare. |
|
Also, it looks like the workflow is getting stuck here. I wonder if it's because this PR modifies a workflow and there is an additional approval required for the bot (or something)? |
|
This action is not yet approved by our admin, need to reach out to them first: |
Thanks. That explains it. Let's not reach out just yet -- the alternative of using sccache that @cpcloud suggested seems to be already approved, and if it works, we might as well go with it: #1156 |
|
/ok to test |
|
/ok to test |
This enables ccache on our non-Windows builds. This should make builds significantly faster.
(I'm going to run CI twice here to confirm it works as advertised.)