Skip to content

Don't strip symbols when building in --debug mode#1219

Merged
mdboom merged 1 commit intoNVIDIA:mainfrom
mdboom:dont-strip-in-debug-mode
Nov 5, 2025
Merged

Don't strip symbols when building in --debug mode#1219
mdboom merged 1 commit intoNVIDIA:mainfrom
mdboom:dont-strip-in-debug-mode

Conversation

@mdboom
Copy link
Copy Markdown
Contributor

@mdboom mdboom commented Nov 5, 2025

Description

In cuda_bindings, the debug symbols are stripped from the .so files, even when passing the --debug flag. This makes it harder to debug in gdb or use valgrind etc.

@mdboom mdboom self-assigned this Nov 5, 2025
@mdboom mdboom added bug Something isn't working packaging Anything related to wheels or Conda packages cuda.bindings Everything related to the cuda.bindings module labels Nov 5, 2025
@copy-pr-bot
Copy link
Copy Markdown
Contributor

copy-pr-bot Bot commented Nov 5, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Copy link
Copy Markdown
Contributor

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better!

@mdboom mdboom enabled auto-merge (squash) November 5, 2025 19:20
@mdboom
Copy link
Copy Markdown
Contributor Author

mdboom commented Nov 5, 2025

/ok to test

@copy-pr-bot
Copy link
Copy Markdown
Contributor

copy-pr-bot Bot commented Nov 5, 2025

/ok to test

@mdboom, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

@mdboom
Copy link
Copy Markdown
Contributor Author

mdboom commented Nov 5, 2025

/ok to test a94010b

@github-actions

This comment has been minimized.

@mdboom mdboom merged commit 3dcdd6d into NVIDIA:main Nov 5, 2025
60 checks passed
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 5, 2025

Doc Preview CI
Preview removed because the pull request was closed or merged.

@leofang leofang added this to the cuda-python 13-next, 12-next milestone Nov 10, 2025
@mdboom mdboom deleted the dont-strip-in-debug-mode branch December 9, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cuda.bindings Everything related to the cuda.bindings module packaging Anything related to wheels or Conda packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants