Skip to content

Conversation

@leofang
Copy link
Member

@leofang leofang commented Nov 20, 2025

Description

follow-up of #1242
closes #1276

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@leofang leofang self-assigned this Nov 20, 2025
@leofang leofang added bug Something isn't working P0 High priority - Must do! test Improvements or additions to tests cuda.core Everything related to the cuda.core module labels Nov 20, 2025
@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Nov 20, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang leofang added this to the cuda.core beta 10 milestone Nov 20, 2025
@leofang
Copy link
Member Author

leofang commented Nov 20, 2025

/ok to test 3dd1bc5

@leofang
Copy link
Member Author

leofang commented Nov 20, 2025

Ah... On the self-hosted Windows runners we don't have MSVC, so CFFI would not work 😞

@github-actions
Copy link

@kkraus14
Copy link
Collaborator

My 2c: having this OBJECT_ATTRIBUTE directly exposed to cuda.core doesn't make sense where I wonder if we can pull out the key functionality that is needed from it and support those more directly via args/kwargs to hide this as an implementation detail from users. If they need the low level functionality they can always reach for cuda.bindings.driver.

@leofang
Copy link
Member Author

leofang commented Nov 21, 2025

Discussed during the meeting, we want to hide this for now and raise an exception asking users to reach out to us if they use handle_type="win32". I'll prepare another PR to do this.

@leofang leofang closed this Nov 21, 2025
@leofang leofang deleted the fix_vmm_tests branch November 21, 2025 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cuda.core Everything related to the cuda.core module P0 High priority - Must do! test Improvements or additions to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix VMM test suite

2 participants