test: avoid leaving files around during ProgramOptions testing
#1372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test |
This comment has been minimized.
This comment has been minimized.
cpcloud
changed the title
ProgramOptions testing
kkraus14
approved these changes
Dec 15, 2025
|
|
||
| @pytest.mark.skipif( | ||
| (_get_nvrtc_version_for_tests() or 0) < 13000, | ||
| reason="buggy with NVRTC < 13.0 (File 'trace.json.json' could not be opened)", |
Collaborator
There was a problem hiding this comment.
nitpick but can we make this trace.json instead of trace.json.json? 😆
Member
There was a problem hiding this comment.
That is the bug that led to this skip condition. We set the filename to trace.json but NVRTC 12.9 insisted to look for trace.json.json.
leofang
approved these changes
Dec 16, 2025
leofang
added
enhancement
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small test refactor to avoid dumping files in
$PWDduringProgramOptionstesting.