Skip to content

cuda.core v0.5.0 doc final pass #1401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
leofang merged 4 commits into from
Dec 17, 2025
Merged

cuda.core v0.5.0 doc final pass #1401

leofang merged 4 commits into from
Dec 17, 2025

Conversation

@leofang
Copy link
Member

@leofang leofang commented Dec 17, 2025

Description

closes

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Dec 17, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang
Copy link
Member Author

leofang commented Dec 17, 2025

/ok to test 8cdac2e

cpcloud
cpcloud reviewed Dec 17, 2025
View reviewed changes
cpcloud
cpcloud reviewed Dec 17, 2025
View reviewed changes
Copy link
Contributor

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment, otherwise LGTM.

@github-actions
Copy link

github-actions bot commented Dec 17, 2025

Doc Preview CI

🚀 View preview at
https://nvidia.github.io/cuda-python/pr-preview/pr-1401/

https://nvidia.github.io/cuda-python/pr-preview/pr-1401/cuda-core/

https://nvidia.github.io/cuda-python/pr-preview/pr-1401/cuda-bindings/

https://nvidia.github.io/cuda-python/pr-preview/pr-1401/cuda-pathfinder/


Preview will be ready when the GitHub Pages deployment is complete.

@leofang leofang added this to the cuda.core beta 10 milestone Dec 17, 2025
leofang
leofang commented Dec 17, 2025
View reviewed changes
cuda_core/docs/source/api_private.rst
Copy link
Member Author

@leofang leofang Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: This fixes most of the warnings seen in recent doc build CI runs. The warnings are cleared out now:
https://github.com/NVIDIA/cuda-python/actions/runs/20316169131/job/58361045100?pr=1401#step:20:1187
Though, to my surprise, we still have 3 instead of 0 warnings. We can look into it after the release (or the holidays...)

@leofang
Copy link
Member Author

leofang commented Dec 17, 2025

Admin-merging as per #1377 (comment)

@leofang leofang merged commit 9079c8c into NVIDIA:main Dec 17, 2025
1 check passed
@leofang leofang deleted the doc_followup branch December 17, 2025 21:30
github-actions bot pushed a commit that referenced this pull request Dec 18, 2025
Clean up PR preview folders for 4 closed/merged PRs
b204d86 
Removed preview folders for the following PRs:
- PR #1298
- PR #1397
- PR #1399
- PR #1401
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpcloud cpcloud cpcloud left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

cuda.core beta 10

Development

Successfully merging this pull request may close these issues.

2 participants

@leofang @cpcloud