Skip to content

Have curl check the certificate#1891

Merged
mdboom merged 1 commit intoNVIDIA:mainfrom
mdboom:check-cert
Apr 10, 2026
Merged

Have curl check the certificate#1891
mdboom merged 1 commit intoNVIDIA:mainfrom
mdboom:check-cert

Conversation

@mdboom
Copy link
Copy Markdown
Contributor

@mdboom mdboom commented Apr 10, 2026

curl -k (also curl --insecure) skips the SSL certificate check. This is downloading from a public URL, so it's safe to assume its SSL certs are set up correctly, and if they aren't that's bad and we should fail.

(Suggested by a Claude Opus 4.6 security scan)

@copy-pr-bot
Copy link
Copy Markdown
Contributor

copy-pr-bot bot commented Apr 10, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@mdboom
Copy link
Copy Markdown
Contributor Author

mdboom commented Apr 10, 2026

/ok to test

@github-actions

This comment has been minimized.

@mdboom mdboom marked this pull request as ready for review April 10, 2026 17:04
@mdboom mdboom self-assigned this Apr 10, 2026
@mdboom mdboom added the CI/CD CI/CD infrastructure label Apr 10, 2026
@mdboom mdboom requested a review from leofang April 10, 2026 17:14
@mdboom mdboom merged commit febb540 into NVIDIA:main Apr 10, 2026
92 of 96 checks passed
@github-actions
Copy link
Copy Markdown

Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD CI/CD infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants