Skip to content

Skip the tests when the requested NVML function is unavailable#1898

Merged
rwgk merged 1 commit intoNVIDIA:mainfrom
rluo8:bug_fix
Apr 13, 2026
Merged

Skip the tests when the requested NVML function is unavailable#1898
rwgk merged 1 commit intoNVIDIA:mainfrom
rluo8:bug_fix

Conversation

@rluo8
Copy link
Copy Markdown
Contributor

@rluo8 rluo8 commented Apr 13, 2026

Skip the tests when nvml function couldn't be found in the installed driver.

FAILED tests/system/test_system_device.py::test_addressing_mode - cuda.bindings._internal.utils.FunctionNotFoundError: function nvmlDeviceGetAddressingMode is not found
FAILED tests/system/test_system_device.py::test_repair_status - cuda.bindings._internal.utils.FunctionNotFoundError: function nvmlDeviceGetRepairStatus is not found
FAILED tests/system/test_system_device.py::test_clock - cuda.bindings.nvml.NotFoundError: Not Found

No output when using driver 576.57.
dumpbin /exports C:\Windows\System32\nvml.dll |findstr /i "nvmlDeviceGetAddressingMode nvmlDeviceGetRepairStatus"

After the fix, the tests could be skipped instead of failure.

collected 3 items

tests/system/test_system_device.py::test_clock SKIPPED (Unsupported call for device architecture B...)
tests/system/test_system_device.py::test_repair_status SKIPPED (Unsupported call for device archit...)
tests/system/test_system_device.py::test_addressing_mode SKIPPED (Unsupported call for device arch...)

@github-actions github-actions bot added the Needs-Restricted-Paths-Review PR touches cuda_bindings or cuda_python; only NVIDIA employees may modify these paths; see LICENSEs label Apr 13, 2026
@github-actions

This comment has been minimized.

@rwgk rwgk added this to the cuda.core v1.0.0 milestone Apr 13, 2026
@rwgk rwgk added P0 High priority - Must do! cuda.bindings Everything related to the cuda.bindings module cuda.core Everything related to the cuda.core module labels Apr 13, 2026
@rwgk
Copy link
Copy Markdown
Collaborator

rwgk commented Apr 13, 2026

I saw the Needs-Restricted-Paths-Review label assigned here (the automatic labeling was introduced with PR #1878).

This is the Summary for the CI: Restricted Paths Guard workflow:

Screenshot 2026-04-13 at 08 36 00

I didn't expect to see Author association: CONTRIBUTOR

I'll investigate. I'll clear the label here manually.

@rwgk rwgk removed the Needs-Restricted-Paths-Review PR touches cuda_bindings or cuda_python; only NVIDIA employees may modify these paths; see LICENSEs label Apr 13, 2026
@rwgk rwgk merged commit cfcb81a into NVIDIA:main Apr 13, 2026
182 of 186 checks passed
@github-actions
Copy link
Copy Markdown

Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cuda.bindings Everything related to the cuda.bindings module cuda.core Everything related to the cuda.core module P0 High priority - Must do!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants