Skip to content

Fix pyperf params on CI#1899

Merged
rwgk merged 1 commit intomainfrom
fix-bindings-pyperf-2
Apr 13, 2026
Merged

Fix pyperf params on CI#1899
rwgk merged 1 commit intomainfrom
fix-bindings-pyperf-2

Conversation

@danielfrg
Copy link
Copy Markdown
Contributor

@danielfrg danielfrg commented Apr 13, 2026

Description

closes

Trying to fix the cuda.bindings benchmarks on CI again.

I think dropping the loops params should let pyperf do its calibration and should solve this.

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot
Copy link
Copy Markdown
Contributor

copy-pr-bot bot commented Apr 13, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the Needs-Restricted-Paths-Review PR touches cuda_bindings or cuda_python; only NVIDIA employees may modify these paths; see LICENSEs label Apr 13, 2026
@danielfrg danielfrg self-assigned this Apr 13, 2026
@danielfrg danielfrg added CI/CD CI/CD infrastructure cuda.bindings Everything related to the cuda.bindings module labels Apr 13, 2026
@danielfrg danielfrg requested a review from rwgk April 13, 2026 15:40
@danielfrg
Copy link
Copy Markdown
Contributor Author

/ok to test c2aeeb9

@rwgk rwgk added the P1 Medium priority - Should do label Apr 13, 2026
@danielfrg
Copy link
Copy Markdown
Contributor Author

danielfrg commented Apr 13, 2026

Should I do a couple extra runs here to test this?

@rwgk rwgk removed the Needs-Restricted-Paths-Review PR touches cuda_bindings or cuda_python; only NVIDIA employees may modify these paths; see LICENSEs label Apr 13, 2026
@rwgk
Copy link
Copy Markdown
Collaborator

rwgk commented Apr 13, 2026

I manually cleared the Needs-Restricted-Paths-Review label (see #1878 (comment) for background).

@github-actions

This comment has been minimized.

@danielfrg
Copy link
Copy Markdown
Contributor Author

/ok to test c2aeeb9

@rwgk rwgk merged commit 82e6bb8 into main Apr 13, 2026
179 of 188 checks passed
@rwgk rwgk deleted the fix-bindings-pyperf-2 branch April 13, 2026 17:28
@github-actions

This comment has been minimized.

1 similar comment
@github-actions
Copy link
Copy Markdown

Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD CI/CD infrastructure cuda.bindings Everything related to the cuda.bindings module P1 Medium priority - Should do

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky WSL cuda.bindings benchmark smoke test: pyperf raises ValueError: benchmark function returned zero

2 participants