Skip to content

Drop 3.13t builds from cibuildwheel configuration#1965

Closed
ngoldbaum wants to merge 2 commits intoNVIDIA:mainfrom
ngoldbaum:rm-3.13t-builds
Closed

Drop 3.13t builds from cibuildwheel configuration#1965
ngoldbaum wants to merge 2 commits intoNVIDIA:mainfrom
ngoldbaum:rm-3.13t-builds

Conversation

@ngoldbaum
Copy link
Copy Markdown

Description

See the note at https://cibuildwheel.pypa.io/en/stable/changelog/#v341 and pypa/cibuildwheel#2787.

This option will be removed in the next release of cibuildwheel. It is only needed to produce 3.13t wheels; 3.14t and future free-threaded wheels happen without any special configuration.

According to the 0.5.0 release notes, 3.13t support is already dropped.

I'm going through repositories on GitHub that enable this option and sending in PRs to disable it. Happy to answer questions about this.

If you're curious why 3.13t support is going away so soon, see https://py-free-threading.github.io/ci/#building-free-threaded-wheels-with-cibuildwheel for further guidance.

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot
Copy link
Copy Markdown
Contributor

copy-pr-bot Bot commented Apr 22, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions Bot added Needs-Restricted-Paths-Review PR touches cuda_bindings or cuda_python; only NVIDIA employees may modify these paths; see LICENSEs cuda.bindings Everything related to the cuda.bindings module cuda.core Everything related to the cuda.core module and removed Needs-Restricted-Paths-Review PR touches cuda_bindings or cuda_python; only NVIDIA employees may modify these paths; see LICENSEs labels Apr 22, 2026
@leofang
Copy link
Copy Markdown
Member

leofang commented Apr 22, 2026

@rwgk it seems the automation applied the label but mistakenly removed it right away:
截圖 2026-04-22 下午5 50 47

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should have triggered the red label.

(Sorry, Nathan, nothing wrong on your side, it's just that we can't accept any external contribution touching files under cuda_bindings/ and cuda_python/ directories, and in the past few days we've been tweaking the automation to make sure we can catch such events.)

@rwgk
Copy link
Copy Markdown
Contributor

rwgk commented Apr 23, 2026

@rwgk it seems the automation applied the label but mistakenly removed it right away: 截圖 2026-04-22 下午5 50 47

I just posted my best guess as to what happened: issue #1967

@rwgk
Copy link
Copy Markdown
Contributor

rwgk commented Apr 23, 2026

Closing in favor of PR #1968

Thanks @ngoldbaum for the heads-up!

@rwgk rwgk closed this Apr 23, 2026
@leofang leofang reopened this Apr 24, 2026
@github-actions github-actions Bot added the Needs-Restricted-Paths-Review PR touches cuda_bindings or cuda_python; only NVIDIA employees may modify these paths; see LICENSEs label Apr 24, 2026
@leofang
Copy link
Copy Markdown
Member

leofang commented Apr 24, 2026

(sorry for noise, I am using this PR to debug a race condition.)

@leofang leofang closed this Apr 24, 2026
@leofang leofang removed the Needs-Restricted-Paths-Review PR touches cuda_bindings or cuda_python; only NVIDIA employees may modify these paths; see LICENSEs label Apr 24, 2026
@leofang leofang reopened this Apr 24, 2026
@github-actions github-actions Bot added the Needs-Restricted-Paths-Review PR touches cuda_bindings or cuda_python; only NVIDIA employees may modify these paths; see LICENSEs label Apr 24, 2026
@leofang leofang closed this Apr 24, 2026
@leofang leofang reopened this Apr 24, 2026
@leofang leofang removed the Needs-Restricted-Paths-Review PR touches cuda_bindings or cuda_python; only NVIDIA employees may modify these paths; see LICENSEs label Apr 24, 2026
@github-actions github-actions Bot added the Needs-Restricted-Paths-Review PR touches cuda_bindings or cuda_python; only NVIDIA employees may modify these paths; see LICENSEs label Apr 24, 2026
@leofang leofang closed this Apr 24, 2026
@leofang leofang reopened this Apr 24, 2026
@leofang

This comment was marked as resolved.

@leofang leofang closed this Apr 24, 2026
@leofang leofang removed the Needs-Restricted-Paths-Review PR touches cuda_bindings or cuda_python; only NVIDIA employees may modify these paths; see LICENSEs label Apr 24, 2026
@leofang
Copy link
Copy Markdown
Member

leofang commented Apr 24, 2026

(nvm, the label showed up after refreshing the page...)

@leofang leofang removed cuda.bindings Everything related to the cuda.bindings module cuda.core Everything related to the cuda.core module Needs-Restricted-Paths-Review PR touches cuda_bindings or cuda_python; only NVIDIA employees may modify these paths; see LICENSEs labels Apr 24, 2026
@github-actions github-actions Bot added Needs-Restricted-Paths-Review PR touches cuda_bindings or cuda_python; only NVIDIA employees may modify these paths; see LICENSEs cuda.bindings Everything related to the cuda.bindings module cuda.core Everything related to the cuda.core module labels Apr 24, 2026
@leofang leofang removed cuda.bindings Everything related to the cuda.bindings module cuda.core Everything related to the cuda.core module Needs-Restricted-Paths-Review PR touches cuda_bindings or cuda_python; only NVIDIA employees may modify these paths; see LICENSEs labels Apr 24, 2026
@github-actions github-actions Bot added cuda.bindings Everything related to the cuda.bindings module cuda.core Everything related to the cuda.core module Needs-Restricted-Paths-Review PR touches cuda_bindings or cuda_python; only NVIDIA employees may modify these paths; see LICENSEs labels Apr 24, 2026
@leofang leofang added Needs-Restricted-Paths-Review PR touches cuda_bindings or cuda_python; only NVIDIA employees may modify these paths; see LICENSEs and removed cuda.bindings Everything related to the cuda.bindings module cuda.core Everything related to the cuda.core module Needs-Restricted-Paths-Review PR touches cuda_bindings or cuda_python; only NVIDIA employees may modify these paths; see LICENSEs labels Apr 24, 2026
@github-actions github-actions Bot added cuda.bindings Everything related to the cuda.bindings module cuda.core Everything related to the cuda.core module labels Apr 24, 2026
@leofang leofang removed cuda.bindings Everything related to the cuda.bindings module cuda.core Everything related to the cuda.core module Needs-Restricted-Paths-Review PR touches cuda_bindings or cuda_python; only NVIDIA employees may modify these paths; see LICENSEs labels Apr 24, 2026
@github-actions github-actions Bot added cuda.bindings Everything related to the cuda.bindings module cuda.core Everything related to the cuda.core module labels Apr 24, 2026
@leofang leofang added Needs-Restricted-Paths-Review PR touches cuda_bindings or cuda_python; only NVIDIA employees may modify these paths; see LICENSEs and removed cuda.bindings Everything related to the cuda.bindings module cuda.core Everything related to the cuda.core module labels Apr 24, 2026
@leofang
Copy link
Copy Markdown
Member

leofang commented Apr 24, 2026

Now this looks more like a real race condition (in the opposite direction):
截圖 2026-04-23 下午10 28 10

In a clean state (no labels):

  • I manually add Need-Review label
  • I then re-ran the labeler workflow right away
  • the labeler workflow correctly added cuda.core/cuda.bindings labels, but they are not actually written to the database
  • the net result is, as of now, only the Need-Review label survives

@leofang leofang marked this pull request as draft April 24, 2026 02:36
@cpcloud
Copy link
Copy Markdown
Contributor

cpcloud commented Apr 24, 2026

This was addressed in #1968.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cuda.bindings Everything related to the cuda.bindings module cuda.core Everything related to the cuda.core module Needs-Restricted-Paths-Review PR touches cuda_bindings or cuda_python; only NVIDIA employees may modify these paths; see LICENSEs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants