BUG: Make nvmlGetFieldValues robust to empty field list#1982
Merged
mdboom merged 2 commits intoNVIDIA:mainfrom Apr 28, 2026
Merged
BUG: Make nvmlGetFieldValues robust to empty field list#1982mdboom merged 2 commits intoNVIDIA:mainfrom
mdboom merged 2 commits intoNVIDIA:mainfrom
Conversation
mdboom
added
cuda.bindings
This comment has been minimized.
This comment has been minimized.
leofang
approved these changes
Apr 28, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nvmlDeviceGetFieldValuesandnvmlDeviceClearFieldValuesraise anINVALID_ARGUMENTerror when given an empty set of field values. This is really confusing from a user perspective: We should just return an empty result in that case.This is inline with what pynvml.py does, so makes it easier to migrate.