Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cuda_core/cuda/core/graph/_subclasses.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -573,7 +573,7 @@ cdef class HostCallbackNode(GraphNode):

Properties
----------
callback_fn : callable or None
callback : callable or None
The Python callable (None for ctypes function pointer callbacks).
"""

Expand Down Expand Up @@ -613,7 +613,7 @@ cdef class HostCallbackNode(GraphNode):
f" cfunc=0x{<uintptr_t>self._fn:x}>")

@property
def callback_fn(self):
def callback(self):
"""The Python callable, or None for ctypes function pointer callbacks."""
return self._callable

Expand Down
4 changes: 4 additions & 0 deletions cuda_core/docs/source/release/1.0.0-notes.rst
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,10 @@ Breaking changes
- New: ``kernel.attributes.num_regs`` and
``kernel.attributes[some_dev].num_regs``

- Renamed :attr:`graph.HostCallbackNode.callback_fn` to
:attr:`graph.HostCallbackNode.callback` to drop the redundant ``_fn`` suffix
(`#1945 <https://github.com/NVIDIA/cuda-python/issues/1945>`__).

- Unified the conditional graph API on :class:`~graph.GraphCondition`
and consistent verbs
(`#1945 <https://github.com/NVIDIA/cuda-python/issues/1945>`__):
Expand Down
2 changes: 1 addition & 1 deletion cuda_core/tests/graph/test_graph_definition.py
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,7 @@ def my_callback():

node = g.callback(my_callback)
return node, {
"callback_fn": lambda v: v is my_callback,
"callback": lambda v: v is my_callback,
}


Expand Down
Loading