Follow-up to #2065: A couple of additional test fixes#2072
Merged
Conversation
github-actions
Bot
added
the
cuda.bindings
This comment has been minimized.
This comment has been minimized.
mdboom
commented
May 12, 2026
| assert s == b"CUDA_ERROR_INVALID_DEVICE" | ||
|
|
||
|
|
||
| @pytest.mark.skipif(not callableBinary("nvidia-smi"), reason="Binary existence needed") |
Contributor
Author
There was a problem hiding this comment.
This test is redundant to this one: https://github.com/NVIDIA/cuda-python/blob/main/cuda_bindings/tests/nvml/test_cuda.py#L57
(Hinted at already in the comment here).
Just removing this seems like the better choice.
github-actions
Bot
added
the
cuda.core
rwgk
approved these changes
May 12, 2026
Contributor
rwgk
left a comment
rwgk
left a comment
There was a problem hiding this comment.
I verified that all Tegra Thor NVML-related errors are resolved with this PR.
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.