Skip to content

Refactor version retrieval for cuda-bindings#2094

Merged
rwgk merged 2 commits into
NVIDIA:mainfrom
ccoulombe:ccoulombe-patch-1
May 16, 2026
Merged

Refactor version retrieval for cuda-bindings#2094
rwgk merged 2 commits into
NVIDIA:mainfrom
ccoulombe:ccoulombe-patch-1

Conversation

@ccoulombe
Copy link
Copy Markdown
Contributor

Description

fix #2093

partition the local version if present, and keep only numeric parts

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

partition the local version if present
@copy-pr-bot
Copy link
Copy Markdown
Contributor

copy-pr-bot Bot commented May 15, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the cuda.core Everything related to the cuda.core module label May 15, 2026
@leofang leofang requested a review from rwgk May 16, 2026 02:47
@leofang leofang added enhancement Any code-related improvements P1 Medium priority - Should do labels May 16, 2026
@rwgk rwgk added bug Something isn't working and removed enhancement Any code-related improvements labels May 16, 2026
Copy link
Copy Markdown
Contributor

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rwgk
Copy link
Copy Markdown
Contributor

rwgk commented May 16, 2026

/ok to test 2a65fcd

@rwgk rwgk enabled auto-merge (squash) May 16, 2026 20:34
@github-actions
Copy link
Copy Markdown

@rwgk rwgk merged commit 92994e4 into NVIDIA:main May 16, 2026
96 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cuda.core Everything related to the cuda.core module P1 Medium priority - Should do

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: Parsing version fails on cuda-core import, since they can have local version

3 participants