Fix #1960: Codify our cuda-core API-auditing process in AGENTS.md#2107
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
kkraus14
approved these changes
May 19, 2026
|
leofang
reviewed
May 19, 2026
Comment on lines
+130
to
+133
| Designs involving manual resource management should be avoided. Where | ||
| appropriate, provide context managers (implemented with `__enter__` and | ||
| `__exit__`, not `contextlib.contextmanager`) or RAII using a `__del__` or | ||
| `__dealloc__` method. |
Member
There was a problem hiding this comment.
this does not match our current design guidelines
Contributor
Author
There was a problem hiding this comment.
The context manager part or the destructor part, or both? We have a ton of the latter in the codebase already.
Member
There was a problem hiding this comment.
Right, I meant the former. But also the whole bullet point in general. For example, all of our public objects have a .close() method, and Phillip ensured that all code samples use them, so this does not hold:
Designs involving manual resource management should be avoided.
Contributor
Author
There was a problem hiding this comment.
Ok. I guess it's more both things, then: an API for manual resource management and helper context managers where appropriate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This codifies the work from #1919. This tries to encode what we /arrived/ at after the whole audit process, not just what we started with in #1919.