-
Notifications
You must be signed in to change notification settings - Fork 305
cuda.core.texture: API-style follow-up before v1.1.0 (#2292) #2307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Andy-Jost
wants to merge
13
commits into
NVIDIA:main
Choose a base branch
from
Andy-Jost:ajost/texture-api-2292
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,501
−929
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
01df88e
cuda.core.texture: rename from_array -> from_opaque_array, element_si…
Andy-Jost 8b52b02
cuda.core.texture: move texture enums to cuda.core.typing as StrEnum …
Andy-Jost b15a9f8
cuda.core.texture: accept NumPy dtypes for array format (#2292)
Andy-Jost 63336a0
cuda.core.texture: rename TextureDescriptor -> TextureObjectOptions (…
Andy-Jost c373a6d
cuda.core.texture: add Device.create_opaque_array / create_mipmapped_…
Andy-Jost b28a1ef
cuda.core.texture: add Device.create_texture_object / create_surface_…
Andy-Jost 0767000
cuda.core.texture: apply pre-commit (ruff, ruff-format, stubgen) (#2292)
Andy-Jost fdc9b29
Merge branch 'main' into ajost/texture-api-2292
Andy-Jost 16940d7
cuda.core.texture: address API-review follow-ups (#2292)
Andy-Jost 57bcf4c
cuda.core.texture: fix stale address_mode entry-rejection test (#2292)
Andy-Jost 60d36b7
cuda.core.texture: register new StrEnums in enum-coverage test (#2292)
Andy-Jost 527fd65
Merge remote-tracking branch 'origin/main' into ajost/texture-api-2292
Andy-Jost 7afd188
Merge branch 'ajost/texture-api-2292' of github.com:Andy-Jost/cuda-py…
Andy-Jost File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #2311. I think this behavior (using the current context rather than the device specified by
self) is buggy, but it matches other methods likeDevice.create_streamandDevice.create_event. Fixing it is out of scope for this PR.