-
Notifications
You must be signed in to change notification settings - Fork 225
Rebase to CTK 12.8 #414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebase to CTK 12.8 #414
Conversation
|
I expect our CI to fail until the cuda-version gets updated to 12.8. |
|
Yes, we need to wait until 12.8.0 appears here:
|
|
@vzhurba01 12.8 is up, could you try to update the workflow files and see how things go? |
|
/ok to test |
|
ah nice you've already updated the workflow, thanks 🙏 |
This comment has been minimized.
This comment has been minimized.
ksimpson-work
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved conditionally on the CI :)
|
CI seems to function surprisingly smoothly (except for the awkwardly long queue). Considering the steps of the CTK release process (binary archives, wheels, ...) it is actually well executed! |
|
Taking a note before merging; @ksimpson-work we should ensure the following are addressed before release.
|
|
Merging, thanks Vlad! |
|
Hooray! 🥳 Thanks Leo, Vlad, and Keenan 🙏 |
|
No description provided.