Skip to content

Conversation

@vzhurba01
Copy link
Contributor

No description provided.

@vzhurba01 vzhurba01 added P0 High priority - Must do! cuda.bindings Everything related to the cuda.bindings module labels Jan 23, 2025
@vzhurba01 vzhurba01 self-assigned this Jan 23, 2025
@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Jan 23, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@vzhurba01
Copy link
Contributor Author

https://anaconda.org/conda-forge/cuda-version

I expect our CI to fail until the cuda-version gets updated to 12.8.

@leofang
Copy link
Member

leofang commented Jan 23, 2025

Yes, we need to wait until 12.8.0 appears here:
https://developer.download.nvidia.com/compute/cuda/redist/
then we update the CI to use 12.8 packages:

@leofang leofang added blocked This task is currently blocked by other tasks feature New feature or request labels Jan 23, 2025
@leofang
Copy link
Member

leofang commented Jan 23, 2025

@vzhurba01 12.8 is up, could you try to update the workflow files and see how things go?
https://developer.download.nvidia.com/compute/cuda/redist/redistrib_12.8.0.json

@vzhurba01
Copy link
Contributor Author

/ok to test

@leofang
Copy link
Member

leofang commented Jan 23, 2025

ah nice you've already updated the workflow, thanks 🙏

@github-actions

This comment has been minimized.

Copy link
Contributor

@ksimpson-work ksimpson-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved conditionally on the CI :)

@leofang
Copy link
Member

leofang commented Jan 24, 2025

CI seems to function surprisingly smoothly (except for the awkwardly long queue). Considering the steps of the CTK release process (binary archives, wheels, ...) it is actually well executed!

@leofang
Copy link
Member

leofang commented Jan 24, 2025

Taking a note before merging; @ksimpson-work we should ensure the following are addressed before release.

  • cuda-python has no release notes for 11.8.6 & 12.8.0
  • cuda-bindings needs to update the release notes to 12.8.0
  • cuda-bindings 11.8.x branch needs to bump the version number to 11.8.6 and add a release note

@leofang
Copy link
Member

leofang commented Jan 24, 2025

Merging, thanks Vlad!

@leofang leofang merged commit 6247324 into NVIDIA:main Jan 24, 2025
71 checks passed
@leofang leofang removed the blocked This task is currently blocked by other tasks label Jan 24, 2025
@jakirkham
Copy link
Collaborator

Hooray! 🥳

Thanks Leo, Vlad, and Keenan 🙏

@github-actions
Copy link

Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cuda.bindings Everything related to the cuda.bindings module feature New feature or request P0 High priority - Must do!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants