Skip to content

Remove profile directive from cuda_bindings default Cython build settings#787

Merged
leofang merged 1 commit intoNVIDIA:mainfrom
vyasr:fix/cuda_bindings_build_profile
Jul 30, 2025
Merged

Remove profile directive from cuda_bindings default Cython build settings#787
leofang merged 1 commit intoNVIDIA:mainfrom
vyasr:fix/cuda_bindings_build_profile

Conversation

@vyasr
Copy link
Copy Markdown
Contributor

@vyasr vyasr commented Jul 29, 2025

Description

closes #786

This PR removes the default setting of having profiling support embedded in Cython builds.

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot
Copy link
Copy Markdown
Contributor

copy-pr-bot Bot commented Jul 29, 2025

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@kkraus14
Copy link
Copy Markdown
Collaborator

/ok to test

@github-actions

This comment has been minimized.

Copy link
Copy Markdown

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I agree with this change.

@github-project-automation github-project-automation Bot moved this from Todo to In Review in CCCL Jul 30, 2025
@leofang leofang self-assigned this Jul 30, 2025
@leofang leofang added enhancement Any code-related improvements P0 High priority - Must do! cuda.bindings Everything related to the cuda.bindings module labels Jul 30, 2025
@leofang leofang added this to the cuda-python 12-next, 11-next milestone Jul 30, 2025
@leofang leofang merged commit f336027 into NVIDIA:main Jul 30, 2025
56 checks passed
@github-project-automation github-project-automation Bot moved this from In Review to Done in CCCL Jul 30, 2025
@github-actions
Copy link
Copy Markdown

Doc Preview CI
Preview removed because the pull request was closed or merged.

@leofang leofang mentioned this pull request Jul 30, 2025
2 tasks
@vyasr vyasr deleted the fix/cuda_bindings_build_profile branch July 30, 2025 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cuda.bindings Everything related to the cuda.bindings module enhancement Any code-related improvements P0 High priority - Must do!

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Should cuda bindings be building with profile support

4 participants