Update with whitespace-only changes from cython-gen #924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
leofang
approved these changes
Aug 28, 2025
leofang
added
enhancement
This comment has been minimized.
This comment has been minimized.
|
Thanks @mdboom. I think we want to backport this as well? |
|
I don't think we have this issue on 12.9.x, since we didn't merge any hand-written changes in generated files on that branch. |
#836 was hand-written, but I think all whitespace changes were absorbed in the backport #900. I confirmed rerunning the codegen for driver/runtime/nvrtc targeting 12.9.x does not generate any diff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just commits to main the results from the latest version of the generator that are whitespace only. I think we got in this state because some "written by hand" changes to the generated code were merged, and then the ports to the generator didn't match that exactly. While none of these changes should have any effect, this will just help future runs of the generator apply cleanly.