[core] Fix issues with lowering to value semantics.#4285
Merged
schweitzpgi merged 4 commits intoNVIDIA:mainfrom Apr 10, 2026
Merged
[core] Fix issues with lowering to value semantics.#4285schweitzpgi merged 4 commits intoNVIDIA:mainfrom
schweitzpgi merged 4 commits intoNVIDIA:mainfrom
Conversation
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
sacpis
approved these changes
Apr 9, 2026
Collaborator
sacpis
left a comment
sacpis
left a comment
There was a problem hiding this comment.
Overall LGTM. Thanks @schweitzpgi. Few questions and comments.
Fix various bugs and issues so that one can add memtoreg just prior to conversion to the QIR API and generate correct code. With these changes all target tests (end-to-end) pass. The memtoreg passes are DISABLED by default. Signed-off-by: Eric Schweitz <eschweitz@nvidia.com>
Signed-off-by: Eric Schweitz <eschweitz@nvidia.com>
schweitzpgi
force-pushed
the
ch-value.bugfix
branch
from
654a22d to
4ee5813
Compare
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
mitchdz
added a commit
to mitchdz/cuda-quantum
that referenced
this pull request
Apr 15, 2026
Fix various bugs and issues so that one can add memtoreg just prior to conversion to the QIR API and generate correct code. With these changes all target tests (end-to-end) pass. The memtoreg passes are DISABLED by default. --------- Signed-off-by: Eric Schweitz <eschweitz@nvidia.com> Co-authored-by: Mitchell <mitch_dz@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix various bugs and issues so that one can add memtoreg just prior to conversion to the QIR API and generate correct code. With these changes all target tests (end-to-end) pass. The memtoreg passes are DISABLED by default.