Fix macOS xdist crash in GHZ noise validation test#4305
Open
KevinSailema wants to merge 1 commit intoNVIDIA:mainfrom
Open
Fix macOS xdist crash in GHZ noise validation test#4305KevinSailema wants to merge 1 commit intoNVIDIA:mainfrom
KevinSailema wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Addresses NVIDIA#4281 by hardening target lifecycle in test_simple_run_ghz_with_noise and running that test serially on macOS validation while keeping the rest of core tests parallel.
mitchdz
reviewed
Apr 16, 2026
|
|
||
| macos_serial_core_tests=() | ||
| if $is_macos; then | ||
| ghz_noise_test="test_simple_run_ghz_with_noise" |
Collaborator
There was a problem hiding this comment.
I'm not a fan of hardcoding the test here.
I don't believe it always fails this test specifically - I started creating GH issues once I see them to try and paint a better picture. I think the failing test is random, and has something to do with the runner environment likely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4281.
Root cause addressed
What changed
Why this approach
Validation
Impact