Skip to content

Fixing Krylov notebook failure#4348

Merged
sacpis merged 1 commit intoNVIDIA:mainfrom
sacpis:fix_publishing_failure_in_krylov
Apr 20, 2026
Merged

Fixing Krylov notebook failure#4348
sacpis merged 1 commit intoNVIDIA:mainfrom
sacpis:fix_publishing_failure_in_krylov

Conversation

@sacpis
Copy link
Copy Markdown
Collaborator

@sacpis sacpis commented Apr 18, 2026

Skipping identity terms when building the Pauli word and coefficient lists passed to the Krylov kernel. Controlled exp_pauli does not handle the identity terms. We add their contribution back when assembling the Hamiltonian matrix.

Fixes https://github.com/NVIDIA/cuda-quantum/actions/runs/24584888146/job/71904057326#step:5:1955

Signed-off-by: Sachin Pisal <spisal@nvidia.com>
@sacpis sacpis requested a review from mitchdz April 18, 2026 04:08
github-actions Bot pushed a commit that referenced this pull request Apr 18, 2026
@github-actions
Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

@sacpis sacpis requested a review from 1tnguyen April 19, 2026 22:30
Copy link
Copy Markdown
Collaborator

@1tnguyen 1tnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sacpis sacpis added this pull request to the merge queue Apr 20, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 20, 2026
@sacpis sacpis added this pull request to the merge queue Apr 20, 2026
Merged via the queue into NVIDIA:main with commit 863db90 Apr 20, 2026
209 checks passed
@sacpis sacpis deleted the fix_publishing_failure_in_krylov branch April 20, 2026 05:31
github-actions Bot pushed a commit that referenced this pull request Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants