Skip to content

Replacing llvm type registry with our own#4385

Merged
Renaud-K merged 2 commits intoNVIDIA:mainfrom
Renaud-K:cudaq-registry
Apr 24, 2026
Merged

Replacing llvm type registry with our own#4385
Renaud-K merged 2 commits intoNVIDIA:mainfrom
Renaud-K:cudaq-registry

Conversation

@Renaud-K
Copy link
Copy Markdown
Collaborator

@Renaud-K Renaud-K commented Apr 23, 2026

While exploring and prototyping options for compile-time checks of QPUs, I keep running into the issue that llvm headers bleed into user code. I would like to put an end to this issue once and for all by replacing it with our own registry.

This registry is widely borrowed from LLVM by Claude and reviewed by codex. I have asked it to keep the current model, whereby it is instantiated in one place so that a registration from a shared lib is visible to all shared libs.

I believe, from discussions with Bruno, that this should also help the LLVM update work.

Signed-off-by: Renaud Kauffmann <rkauffmann@nvidia.com>
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Apr 23, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@Renaud-K
Copy link
Copy Markdown
Collaborator Author

Renaud-K commented Apr 23, 2026

/ok to test 4916cae

Command Bot: Processing...

Comment thread lib/Optimizer/Transforms/DecompositionPatterns.cpp Outdated
Comment thread runtime/common/Registry.h
github-actions Bot pushed a commit that referenced this pull request Apr 24, 2026
@github-actions
Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

Signed-off-by: Renaud Kauffmann <rkauffmann@nvidia.com>
@Renaud-K
Copy link
Copy Markdown
Collaborator Author

Renaud-K commented Apr 24, 2026

/ok to test 3b858e0

Command Bot: Processing...

Comment thread runtime/common/Registry.h
@Renaud-K Renaud-K enabled auto-merge April 24, 2026 20:31
@Renaud-K Renaud-K added this pull request to the merge queue Apr 24, 2026
github-actions Bot pushed a commit that referenced this pull request Apr 24, 2026
@github-actions
Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

Merged via the queue into NVIDIA:main with commit 1099783 Apr 24, 2026
209 checks passed
@Renaud-K Renaud-K deleted the cudaq-registry branch April 24, 2026 21:48
github-actions Bot pushed a commit that referenced this pull request Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants