Reduced QPU headers dependency on JSON and LLVM/MLIR by Renaud-K · Pull Request #4416 · NVIDIA/cuda-quantum

Renaud-K · 2026-04-29T23:44:49Z

The end goal is to be able to have QPU headers visible from user code, so compile-time checks can be performed based on QPU traits without leaking headers from 3rd party libraries.

Importing the latest nlohmann::json library which introduces a header for forward declaration of the nlohmann::json type.
- Using FectchContent
- Removed tpls/json
- Exporting json_fwd.hpp in the install tree
- Introducing the cudaq_json type to encapsulate the forward declared nlohmann::json. Only needed by KernelExecution
- Only including the full nlohmann::json type in .cpp files.
Adding to the build tree, the files newly needed at runtime to enable nvq++ to run from the build tree
(TargetConfig.h Version.h json_fwd.hpp)
Moved Fermioniq implementation that was using nlohmann::json to the .cpp file. Merged FermioniqQPU with FermioniqBaseQPU.
Introduced qpu_utils.{h,cpp} to prevent header includes to bleed through the qpu headers. This, for now, stops the inclusion of:

#include "cudaq/Optimizer/Builder/RuntimeNames.h"
#include "cudaq/Support/TargetConfig.h"
#include "cudaq/Support/TargetConfigYaml.h"
#include "llvm/Support/Base64.h"

Using ModuleOp::getFromOpaquePointer, ModuleOp::getAsOpaquePointer and an MLIRContextDesctuctor to pass the MLIR modules and contexts through the QPUs.
This is a stop gap until we have a unified launch interface @lmondada is working on.

1tnguyen

LGTM 💯

Just one question about FetchContent vs. submodule convention.

lmondada

Thank you, nice clean up!

copy-pr-bot · 2026-04-30T14:57:53Z

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Renaud-K · 2026-04-30T21:07:34Z

/ok to test f4af53f

Command Bot: Processing...

Renaud-K · 2026-05-01T00:26:37Z

/ok to test e54f557

Command Bot: Processing...

copy-pr-bot · 2026-05-01T00:26:40Z

/ok to test e54f557

@Renaud-K, there was an error processing your request: E2

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/2/

Renaud-K · 2026-05-01T00:59:50Z

/ok to test 2e10327

Command Bot: Processing...

Renaud-K · 2026-05-01T15:36:57Z

/ok to test 8970475

Command Bot: Processing...

Signed-off-by: Renaud Kauffmann <rkauffmann@nvidia.com>

Renaud-K · 2026-05-01T19:01:42Z

/ok to test 44c04ad

Command Bot: Processing...

github-actions · 2026-05-01T19:45:36Z

CI Summary — ✅ passed

Run #25234244180 · trigger merge_group · ✅ 13 · ⏩ 0 · ❌ 0 · ⛔ 0

Top-level jobs (13)

Job	Result
`binaries`	✅ success
`build_and_test`	✅ success
`config_devdeps`	✅ success
`config_source_build`	✅ success
`config_wheeldeps`	✅ success
`devdeps`	✅ success
`docker_image`	✅ success
`gen_code_coverage`	✅ success
`metadata`	✅ success
`python_metapackages`	✅ success
`python_wheels`	✅ success
`source_build`	✅ success
`wheeldeps`	✅ success

All sub-jobs (188) — every matrix leg, with links

Job	Status	Link
Build and test (amd64, clang16, openmpi) / Dev environment (Debug)	✅ success	view
Build and test (amd64, clang16, openmpi) / Dev environment (Python)	✅ success	view
Build and test (amd64, gcc11, openmpi) / Dev environment (Debug)	✅ success	view
Build and test (amd64, gcc11, openmpi) / Dev environment (Python)	✅ success	view
Build and test (amd64, gcc12, openmpi) / Dev environment (Debug)	✅ success	view
Build and test (amd64, gcc12, openmpi) / Dev environment (Python)	✅ success	view
Build and test (arm64, clang16, openmpi) / Dev environment (Debug)	✅ success	view
Build and test (arm64, clang16, openmpi) / Dev environment (Python)	✅ success	view
Build and test (arm64, gcc11, openmpi) / Dev environment (Debug)	✅ success	view
Build and test (arm64, gcc11, openmpi) / Dev environment (Python)	✅ success	view
Build and test (arm64, gcc12, openmpi) / Dev environment (Debug)	✅ success	view
Build and test (arm64, gcc12, openmpi) / Dev environment (Python)	✅ success	view
CI Summary	❔ in_progress	view
Configure build (devdeps)	✅ success	view
Configure build (source_build)	✅ success	view
Configure build (wheeldeps)	✅ success	view
Create CUDA Quantum installer (amd64, 12.6) / Build CUDA Quantum assets	✅ success	view
Create CUDA Quantum installer (amd64, 12.6) / Minimal OpenMPI installation	✅ success	view
Create CUDA Quantum installer (amd64, 12.6) / Prepare cache clean-up	✅ success	view
Create CUDA Quantum installer (amd64, 12.6) / Prepare validation	✅ success	view
Create CUDA Quantum installer (amd64, 12.6) / Staging	⏩ skipped	view
Create CUDA Quantum installer (amd64, 12.6) / Validate installer (debian:12)	✅ success	view
Create CUDA Quantum installer (amd64, 12.6) / Validate installer (fedora:42)	✅ success	view
Create CUDA Quantum installer (amd64, 12.6) / Validate installer (opensuse/leap:15.5)	✅ success	view
Create CUDA Quantum installer (amd64, 12.6) / Validate installer (redhat/ubi9:9.6)	✅ success	view
Create CUDA Quantum installer (amd64, 12.6) / Validate installer (ubuntu:22.04)	✅ success	view
Create CUDA Quantum installer (amd64, 13.0) / Build CUDA Quantum assets	✅ success	view
Create CUDA Quantum installer (amd64, 13.0) / Minimal OpenMPI installation	✅ success	view
Create CUDA Quantum installer (amd64, 13.0) / Prepare cache clean-up	✅ success	view
Create CUDA Quantum installer (amd64, 13.0) / Prepare validation	✅ success	view
Create CUDA Quantum installer (amd64, 13.0) / Staging	⏩ skipped	view
Create CUDA Quantum installer (amd64, 13.0) / Validate installer (debian:12)	✅ success	view
Create CUDA Quantum installer (amd64, 13.0) / Validate installer (fedora:42)	✅ success	view
Create CUDA Quantum installer (amd64, 13.0) / Validate installer (opensuse/leap:15.5)	✅ success	view
Create CUDA Quantum installer (amd64, 13.0) / Validate installer (ubuntu:22.04)	✅ success	view
Create CUDA Quantum installer (arm64, 12.6) / Build CUDA Quantum assets	✅ success	view
Create CUDA Quantum installer (arm64, 12.6) / Minimal OpenMPI installation	✅ success	view
Create CUDA Quantum installer (arm64, 12.6) / Prepare cache clean-up	✅ success	view
Create CUDA Quantum installer (arm64, 12.6) / Prepare validation	✅ success	view
Create CUDA Quantum installer (arm64, 12.6) / Staging	⏩ skipped	view
Create CUDA Quantum installer (arm64, 12.6) / Validate installer (redhat/ubi9:9.6)	✅ success	view
Create CUDA Quantum installer (arm64, 12.6) / Validate installer (ubuntu:22.04)	✅ success	view
Create CUDA Quantum installer (arm64, 13.0) / Build CUDA Quantum assets	✅ success	view
Create CUDA Quantum installer (arm64, 13.0) / Minimal OpenMPI installation	✅ success	view
Create CUDA Quantum installer (arm64, 13.0) / Prepare cache clean-up	✅ success	view
Create CUDA Quantum installer (arm64, 13.0) / Prepare validation	✅ success	view
Create CUDA Quantum installer (arm64, 13.0) / Staging	⏩ skipped	view
Create CUDA Quantum installer (arm64, 13.0) / Validate installer (ubuntu:22.04)	✅ success	view
Create Docker images (amd64) / Documentation	✅ success	view
Create Docker images (amd64) / Metadata	✅ success	view
Create Docker images (amd64) / Prepare cache clean-up	✅ success	view
Create Docker images (amd64) / Staging	⏩ skipped	view
Create Docker images (amd64) / Validation	✅ success	view
Create Docker images (amd64) / cuda-quantum (release)	✅ success	view
Create Docker images (amd64) / cuda-quantum-dev (debug)	✅ success	view
Create Docker images (amd64) / open-mpi	⏩ skipped	view
Create Docker images (arm64) / Documentation	⏩ skipped	view
Create Docker images (arm64) / Metadata	✅ success	view
Create Docker images (arm64) / Prepare cache clean-up	✅ success	view
Create Docker images (arm64) / Staging	⏩ skipped	view
Create Docker images (arm64) / Validation	✅ success	view
Create Docker images (arm64) / cuda-quantum (release)	✅ success	view
Create Docker images (arm64) / cuda-quantum-dev (debug)	✅ success	view
Create Docker images (arm64) / open-mpi	⏩ skipped	view
Create Python metapackages / Build Python metapackages	✅ success	view
Create Python metapackages / Test Python metapackages (12.6, 3.11)	✅ success	view
Create Python metapackages / Test Python metapackages (12.6, 3.13)	✅ success	view
Create Python metapackages / Test Python metapackages (13.0, 3.11)	✅ success	view
Create Python metapackages / Test Python metapackages (13.0, 3.13)	✅ success	view
Create Python metapackages / Test Python metapackages (3.11)	✅ success	view
Create Python metapackages / Test Python metapackages (3.13)	✅ success	view
Create Python wheels (amd64, 3.11, 12.6) / Build Python 3.11 wheel	✅ success	view
Create Python wheels (amd64, 3.11, 12.6) / Prepare validation	✅ success	view
Create Python wheels (amd64, 3.11, 12.6) / Staging	⏩ skipped	view
Create Python wheels (amd64, 3.11, 12.6) / Validate wheel (debian:12)	✅ success	view
Create Python wheels (amd64, 3.11, 12.6) / Validate wheel (debian:12, --user)	✅ success	view
Create Python wheels (amd64, 3.11, 12.6) / Validate wheel (fedora:42)	✅ success	view
Create Python wheels (amd64, 3.11, 12.6) / Validate wheel (fedora:42, --user)	✅ success	view
Create Python wheels (amd64, 3.11, 12.6) / Validate wheel (redhat/ubi8:8.10)	✅ success	view
Create Python wheels (amd64, 3.11, 12.6) / Validate wheel (redhat/ubi8:8.10, --user)	✅ success	view
Create Python wheels (amd64, 3.11, 12.6) / Validate wheel (redhat/ubi9:9.6)	✅ success	view
Create Python wheels (amd64, 3.11, 12.6) / Validate wheel (redhat/ubi9:9.6, --user)	✅ success	view
Create Python wheels (amd64, 3.11, 12.6) / Validate wheel (ubuntu:22.04)	✅ success	view
Create Python wheels (amd64, 3.11, 12.6) / Validate wheel (ubuntu:22.04, --user)	✅ success	view
Create Python wheels (amd64, 3.11, 13.0) / Build Python 3.11 wheel	✅ success	view
Create Python wheels (amd64, 3.11, 13.0) / Prepare validation	✅ success	view
Create Python wheels (amd64, 3.11, 13.0) / Staging	⏩ skipped	view
Create Python wheels (amd64, 3.11, 13.0) / Validate wheel (debian:12)	✅ success	view
Create Python wheels (amd64, 3.11, 13.0) / Validate wheel (debian:12, --user)	✅ success	view
Create Python wheels (amd64, 3.11, 13.0) / Validate wheel (fedora:42)	✅ success	view
Create Python wheels (amd64, 3.11, 13.0) / Validate wheel (fedora:42, --user)	✅ success	view
Create Python wheels (amd64, 3.11, 13.0) / Validate wheel (redhat/ubi8:8.10)	✅ success	view
Create Python wheels (amd64, 3.11, 13.0) / Validate wheel (redhat/ubi8:8.10, --user)	✅ success	view
Create Python wheels (amd64, 3.11, 13.0) / Validate wheel (redhat/ubi9:9.6)	✅ success	view
Create Python wheels (amd64, 3.11, 13.0) / Validate wheel (redhat/ubi9:9.6, --user)	✅ success	view
Create Python wheels (amd64, 3.11, 13.0) / Validate wheel (ubuntu:22.04)	✅ success	view
Create Python wheels (amd64, 3.11, 13.0) / Validate wheel (ubuntu:22.04, --user)	✅ success	view
Create Python wheels (amd64, 3.13, 12.6) / Build Python 3.13 wheel	✅ success	view
Create Python wheels (amd64, 3.13, 12.6) / Prepare validation	✅ success	view
Create Python wheels (amd64, 3.13, 12.6) / Staging	⏩ skipped	view
Create Python wheels (amd64, 3.13, 12.6) / Validate wheel (fedora:42)	✅ success	view
Create Python wheels (amd64, 3.13, 12.6) / Validate wheel (fedora:42, --user)	✅ success	view
Create Python wheels (amd64, 3.13, 13.0) / Build Python 3.13 wheel	✅ success	view
Create Python wheels (amd64, 3.13, 13.0) / Prepare validation	✅ success	view
Create Python wheels (amd64, 3.13, 13.0) / Staging	⏩ skipped	view
Create Python wheels (amd64, 3.13, 13.0) / Validate wheel (fedora:42)	✅ success	view
Create Python wheels (amd64, 3.13, 13.0) / Validate wheel (fedora:42, --user)	✅ success	view
Create Python wheels (arm64, 3.11, 12.6) / Build Python 3.11 wheel	✅ success	view
Create Python wheels (arm64, 3.11, 12.6) / Prepare validation	✅ success	view
Create Python wheels (arm64, 3.11, 12.6) / Staging	⏩ skipped	view
Create Python wheels (arm64, 3.11, 12.6) / Validate wheel (debian:12)	✅ success	view
Create Python wheels (arm64, 3.11, 12.6) / Validate wheel (debian:12, --user)	✅ success	view
Create Python wheels (arm64, 3.11, 12.6) / Validate wheel (fedora:42)	✅ success	view
Create Python wheels (arm64, 3.11, 12.6) / Validate wheel (fedora:42, --user)	✅ success	view
Create Python wheels (arm64, 3.11, 12.6) / Validate wheel (redhat/ubi8:8.10)	✅ success	view
Create Python wheels (arm64, 3.11, 12.6) / Validate wheel (redhat/ubi8:8.10, --user)	✅ success	view
Create Python wheels (arm64, 3.11, 12.6) / Validate wheel (redhat/ubi9:9.6)	✅ success	view
Create Python wheels (arm64, 3.11, 12.6) / Validate wheel (redhat/ubi9:9.6, --user)	✅ success	view
Create Python wheels (arm64, 3.11, 12.6) / Validate wheel (ubuntu:22.04)	✅ success	view
Create Python wheels (arm64, 3.11, 12.6) / Validate wheel (ubuntu:22.04, --user)	✅ success	view
Create Python wheels (arm64, 3.11, 13.0) / Build Python 3.11 wheel	✅ success	view
Create Python wheels (arm64, 3.11, 13.0) / Prepare validation	✅ success	view
Create Python wheels (arm64, 3.11, 13.0) / Staging	⏩ skipped	view
Create Python wheels (arm64, 3.11, 13.0) / Validate wheel (debian:12)	✅ success	view
Create Python wheels (arm64, 3.11, 13.0) / Validate wheel (debian:12, --user)	✅ success	view
Create Python wheels (arm64, 3.11, 13.0) / Validate wheel (fedora:42)	✅ success	view
Create Python wheels (arm64, 3.11, 13.0) / Validate wheel (fedora:42, --user)	✅ success	view
Create Python wheels (arm64, 3.11, 13.0) / Validate wheel (redhat/ubi8:8.10)	✅ success	view
Create Python wheels (arm64, 3.11, 13.0) / Validate wheel (redhat/ubi8:8.10, --user)	✅ success	view
Create Python wheels (arm64, 3.11, 13.0) / Validate wheel (redhat/ubi9:9.6)	✅ success	view
Create Python wheels (arm64, 3.11, 13.0) / Validate wheel (redhat/ubi9:9.6, --user)	✅ success	view
Create Python wheels (arm64, 3.11, 13.0) / Validate wheel (ubuntu:22.04)	✅ success	view
Create Python wheels (arm64, 3.11, 13.0) / Validate wheel (ubuntu:22.04, --user)	✅ success	view
Create Python wheels (arm64, 3.13, 12.6) / Build Python 3.13 wheel	✅ success	view
Create Python wheels (arm64, 3.13, 12.6) / Prepare validation	✅ success	view
Create Python wheels (arm64, 3.13, 12.6) / Staging	⏩ skipped	view
Create Python wheels (arm64, 3.13, 12.6) / Validate wheel (fedora:42)	✅ success	view
Create Python wheels (arm64, 3.13, 12.6) / Validate wheel (fedora:42, --user)	✅ success	view
Create Python wheels (arm64, 3.13, 13.0) / Build Python 3.13 wheel	✅ success	view
Create Python wheels (arm64, 3.13, 13.0) / Prepare validation	✅ success	view
Create Python wheels (arm64, 3.13, 13.0) / Staging	⏩ skipped	view
Create Python wheels (arm64, 3.13, 13.0) / Validate wheel (fedora:42)	✅ success	view
Create Python wheels (arm64, 3.13, 13.0) / Validate wheel (fedora:42, --user)	✅ success	view
Gen code coverage (amd64, clang16) / gen_code_coverage	✅ success	view
Load dependencies (amd64, clang16) / Caching	✅ success	view
Load dependencies (amd64, clang16) / Finalize	✅ success	view
Load dependencies (amd64, clang16) / Metadata	✅ success	view
Load dependencies (amd64, gcc11) / Caching	✅ success	view
Load dependencies (amd64, gcc11) / Finalize	✅ success	view
Load dependencies (amd64, gcc11) / Metadata	✅ success	view
Load dependencies (amd64, gcc12) / Caching	✅ success	view
Load dependencies (amd64, gcc12) / Finalize	✅ success	view
Load dependencies (amd64, gcc12) / Metadata	✅ success	view
Load dependencies (arm64, clang16) / Caching	✅ success	view
Load dependencies (arm64, clang16) / Finalize	✅ success	view
Load dependencies (arm64, clang16) / Metadata	✅ success	view
Load dependencies (arm64, gcc11) / Caching	✅ success	view
Load dependencies (arm64, gcc11) / Finalize	✅ success	view
Load dependencies (arm64, gcc11) / Metadata	✅ success	view
Load dependencies (arm64, gcc12) / Caching	✅ success	view
Load dependencies (arm64, gcc12) / Finalize	✅ success	view
Load dependencies (arm64, gcc12) / Metadata	✅ success	view
Load source build cache (amd64, 12.6) / Caching	✅ success	view
Load source build cache (amd64, 12.6) / Finalize	✅ success	view
Load source build cache (amd64, 12.6) / Metadata	✅ success	view
Load source build cache (amd64, 13.0) / Caching	✅ success	view
Load source build cache (amd64, 13.0) / Finalize	✅ success	view
Load source build cache (amd64, 13.0) / Metadata	✅ success	view
Load source build cache (arm64, 12.6) / Caching	✅ success	view
Load source build cache (arm64, 12.6) / Finalize	✅ success	view
Load source build cache (arm64, 12.6) / Metadata	✅ success	view
Load source build cache (arm64, 13.0) / Caching	✅ success	view
Load source build cache (arm64, 13.0) / Finalize	✅ success	view
Load source build cache (arm64, 13.0) / Metadata	✅ success	view
Load wheel dependencies (amd64, 12.6) / Caching	✅ success	view
Load wheel dependencies (amd64, 12.6) / Finalize	✅ success	view
Load wheel dependencies (amd64, 12.6) / Metadata	✅ success	view
Load wheel dependencies (amd64, 13.0) / Caching	✅ success	view
Load wheel dependencies (amd64, 13.0) / Finalize	✅ success	view
Load wheel dependencies (amd64, 13.0) / Metadata	✅ success	view
Load wheel dependencies (arm64, 12.6) / Caching	✅ success	view
Load wheel dependencies (arm64, 12.6) / Finalize	✅ success	view
Load wheel dependencies (arm64, 12.6) / Metadata	✅ success	view
Load wheel dependencies (arm64, 13.0) / Caching	✅ success	view
Load wheel dependencies (arm64, 13.0) / Finalize	✅ success	view
Load wheel dependencies (arm64, 13.0) / Metadata	✅ success	view
Prepare cache clean-up	✅ success	view
Retrieve PR info	✅ success	view

✅ Required checks (35/35) — declared in .github/required-checks.yml for merge_group

Required check	Status	Link
Build and test (arm64, gcc11, openmpi) / Dev environment (Debug)	✅ success	view
Build and test (arm64, gcc11, openmpi) / Dev environment (Python)	✅ success	view
Build and test (arm64, gcc12, openmpi) / Dev environment (Debug)	✅ success	view
Build and test (arm64, gcc12, openmpi) / Dev environment (Python)	✅ success	view
Create CUDA Quantum installer (amd64, 12.6) / Build CUDA Quantum assets	✅ success	view
Create CUDA Quantum installer (amd64, 12.6) / Minimal OpenMPI installation	✅ success	view
Create CUDA Quantum installer (amd64, 12.6) / Validate installer (debian:12)	✅ success	view
Create CUDA Quantum installer (amd64, 12.6) / Validate installer (fedora:42)	✅ success	view
Create CUDA Quantum installer (amd64, 12.6) / Validate installer (opensuse/leap:15.5)	✅ success	view
Create CUDA Quantum installer (amd64, 12.6) / Validate installer (redhat/ubi9:9.6)	✅ success	view
Create CUDA Quantum installer (amd64, 12.6) / Validate installer (ubuntu:22.04)	✅ success	view
Create CUDA Quantum installer (arm64, 12.6) / Build CUDA Quantum assets	✅ success	view
Create CUDA Quantum installer (arm64, 12.6) / Minimal OpenMPI installation	✅ success	view
Create CUDA Quantum installer (arm64, 12.6) / Validate installer (redhat/ubi9:9.6)	✅ success	view
Create CUDA Quantum installer (arm64, 12.6) / Validate installer (ubuntu:22.04)	✅ success	view
Create Docker images (amd64) / Documentation	✅ success	view
Create Docker images (amd64) / Validation	✅ success	view
Create Docker images (arm64) / Validation	✅ success	view
Create Python metapackages / Build Python metapackages	✅ success	view
Create Python metapackages / Test Python metapackages (3.11)	✅ success	view
Create Python metapackages / Test Python metapackages (3.13)	✅ success	view
Create Python metapackages / Test Python metapackages (12.6, 3.11)	✅ success	view
Create Python metapackages / Test Python metapackages (12.6, 3.13)	✅ success	view
Create Python wheels (amd64, 3.11, 12.6) / Validate wheel (debian:12, --user)	✅ success	view
Create Python wheels (amd64, 3.11, 12.6) / Validate wheel (debian:12)	✅ success	view
Create Python wheels (amd64, 3.11, 12.6) / Validate wheel (fedora:42, --user)	✅ success	view
Create Python wheels (amd64, 3.11, 12.6) / Validate wheel (fedora:42)	✅ success	view
Create Python wheels (amd64, 3.11, 12.6) / Validate wheel (redhat/ubi8:8.10, --user)	✅ success	view
Create Python wheels (amd64, 3.11, 12.6) / Validate wheel (redhat/ubi8:8.10)	✅ success	view
Create Python wheels (arm64, 3.11, 12.6) / Validate wheel (debian:12, --user)	✅ success	view
Create Python wheels (arm64, 3.11, 12.6) / Validate wheel (debian:12)	✅ success	view
Create Python wheels (arm64, 3.11, 12.6) / Validate wheel (fedora:42, --user)	✅ success	view
Create Python wheels (arm64, 3.11, 12.6) / Validate wheel (fedora:42)	✅ success	view
Create Python wheels (arm64, 3.11, 12.6) / Validate wheel (redhat/ubi8:8.10, --user)	✅ success	view
Create Python wheels (arm64, 3.11, 12.6) / Validate wheel (redhat/ubi8:8.10)	✅ success	view

Renaud-K requested review from 1tnguyen, bettinaheim, bmhowe23 and mitchdz as code owners April 29, 2026 23:44

Renaud-K requested review from atgeller, boschmitt, lmondada and schweitzpgi April 29, 2026 23:47

1tnguyen reviewed Apr 29, 2026

View reviewed changes

Comment thread CMakeLists.txt Outdated

1tnguyen approved these changes Apr 29, 2026

View reviewed changes

lmondada approved these changes Apr 30, 2026

View reviewed changes

Comment thread runtime/common/BaseRemoteSimulatorQPU.h

Comment thread runtime/internal/compiler/include/cudaq_internal/compiler/Compiler.h Outdated

Renaud-K force-pushed the json-headers branch from 9660d86 to cd0d650 Compare April 30, 2026 14:57

Renaud-K enabled auto-merge April 30, 2026 22:27

Renaud-K force-pushed the json-headers branch from f4af53f to 2e10327 Compare May 1, 2026 00:25

Renaud-K added this pull request to the merge queue May 1, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 1, 2026

Renaud-K added this pull request to the merge queue May 1, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 1, 2026

Renaud-K force-pushed the json-headers branch from 2e10327 to 8970475 Compare May 1, 2026 15:21

Renaud-K enabled auto-merge May 1, 2026 16:25

Renaud-K added 4 commits May 1, 2026 19:00

Reduced QPU headers dependency on JSON and LLVM/MLIR

5614de1

Signed-off-by: Renaud Kauffmann <rkauffmann@nvidia.com>

Adding comments for the changes

f1701e5

Signed-off-by: Renaud Kauffmann <rkauffmann@nvidia.com>

Do not populate header files in 2 locations. It violates ODR.

bc15a06

Signed-off-by: Renaud Kauffmann <rkauffmann@nvidia.com>

Use shared_ptr instead of unique_ptr for MLIR context.

294d354

Signed-off-by: Renaud Kauffmann <rkauffmann@nvidia.com>

Renaud-K added 3 commits May 1, 2026 19:00

Using tpls instead of FetchContent for nholmann/json

fd26afc

Signed-off-by: Renaud Kauffmann <rkauffmann@nvidia.com>

Rebased with latest

113be33

Signed-off-by: Renaud Kauffmann <rkauffmann@nvidia.com>

Updating api doc.

44c04ad

Signed-off-by: Renaud Kauffmann <rkauffmann@nvidia.com>

Renaud-K force-pushed the json-headers branch from 8970475 to 44c04ad Compare May 1, 2026 19:00

Renaud-K added this pull request to the merge queue May 1, 2026

Merged via the queue into NVIDIA:main with commit 4b1138f May 1, 2026
91 checks passed

Renaud-K deleted the json-headers branch May 1, 2026 22:57

github-actions Bot pushed a commit that referenced this pull request May 1, 2026

Cleaning up docs preview for PR #4416.

f08f1d5

Renaud-K mentioned this pull request May 7, 2026

Surface QPU headers into user code to enable compile-time checks. #4469

Open

5 tasks

Conversation

Renaud-K commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

1tnguyen left a comment

Choose a reason for hiding this comment

Uh oh!

lmondada left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

copy-pr-bot Bot commented Apr 30, 2026

Uh oh!

Renaud-K commented Apr 30, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Renaud-K commented May 1, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

copy-pr-bot Bot commented May 1, 2026

Uh oh!

Renaud-K commented May 1, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Renaud-K commented May 1, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Renaud-K commented May 1, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI Summary — ✅ passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Renaud-K commented Apr 29, 2026 •

edited

Loading

Renaud-K commented Apr 30, 2026 •

edited by github-actions Bot

Loading

Renaud-K commented May 1, 2026 •

edited by github-actions Bot

Loading

Renaud-K commented May 1, 2026 •

edited by github-actions Bot

Loading

Renaud-K commented May 1, 2026 •

edited by github-actions Bot

Loading

Renaud-K commented May 1, 2026 •

edited by github-actions Bot

Loading

github-actions Bot commented May 1, 2026 •

edited

Loading