-
Notifications
You must be signed in to change notification settings - Fork 163
Migrate RMM usage to CCCL MR design #1035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
2970a07
536a692
31a6eab
f889d28
76c9ece
24d3036
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,6 +15,8 @@ | |
|
|
||
| #include <mip_heuristics/mip_constants.hpp> | ||
|
|
||
| #include <thrust/iterator/transform_output_iterator.h> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is it an intentional change?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, it is used here: https://github.com/bdice/cuopt/blob/24d30362c1393da1275759e62df0d10ed11dec03/cpp/src/pdlp/termination_strategy/infeasibility_information.cu#L354 I believe this was added to fix a missing header, though it's been a while since I did this. The large changes in headers probably meant that it wasn't being included transitively anymore, but we shouldn't rely on transitive includes anyway. |
||
|
|
||
| #include <raft/sparse/detail/cusparse_wrappers.h> | ||
| #include <raft/core/nvtx.hpp> | ||
| #include <raft/linalg/detail/cublas_wrappers.hpp> | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't seem like this template parameter is being used. The
rmm::mr::device_memory_resourceclass has been removed, but this change in an unused template parameter should have no effect.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirm, it is not used