Skip to content

skill-evolution: drop inline provenance markers#1161

Merged
rapids-bot[bot] merged 2 commits intoNVIDIA:mainfrom
rgsl888prabhu:skill-evo-provenance
Apr 30, 2026
Merged

skill-evolution: drop inline provenance markers#1161
rapids-bot[bot] merged 2 commits intoNVIDIA:mainfrom
rgsl888prabhu:skill-evo-provenance

Conversation

@rgsl888prabhu
Copy link
Copy Markdown
Collaborator

Summary

Removes the <!-- skill-evolution:start --> ... <!-- skill-evolution:end --> HTML-comment marker requirement for inline edits to existing SKILL.md files. The markers add visible noise that compounds across many small edits, while git log / git blame already attribute every line to its origin commit. Audit trail now relies on a clear commit subject (e.g. "skill-evolution: add ... to lp-milp-formulation").

Frontmatter origin: skill-evolution for new skills and # origin: skill-evolution headers for code assets are kept — those edits are creating new files, not editing existing prose.

Distillation checklist updated to remove the marker requirement.

Testing

  • ./ci/utils/validate_skills.sh passes

Docs

  • Skill content only.

@rgsl888prabhu rgsl888prabhu requested a review from a team as a code owner April 29, 2026 21:25
@rgsl888prabhu rgsl888prabhu requested a review from Iroy30 April 29, 2026 21:25
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 29, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d276e102-cc36-420b-8f08-1186f653de9f

📥 Commits

Reviewing files that changed from the base of the PR and between 5f00c1f and a1fa840.

📒 Files selected for processing (1)
  • skills/skill-evolution/SKILL.md

📝 Walkthrough

Walkthrough

The provenance-tagging policy in skills/skill-evolution/SKILL.md was changed: HTML comment boundary markers for inline edits were removed as a requirement; inline additions should avoid those markers and auditability should rely on commit/PR metadata with commit subjects beginning with skill-evolution:. The distillation checklist's marker-wrapping check was replaced by a commit-subject greppability check.

Changes

Cohort / File(s) Summary
Provenance Documentation Updates
skills/skill-evolution/SKILL.md
Removes requirement to wrap inline edits with <!-- skill-evolution:start --> / <!-- skill-evolution:end -->. Adds instruction that inline additions should not use HTML comment markers and that auditability depends on commit/PR metadata, with expectation that commit subject begins with skill-evolution:. Updates distillation checklist: drops marker-wrapping compliance and adds a greppability check for commit subjects.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'skill-evolution: drop inline provenance markers' directly and specifically describes the main change: removing HTML-comment provenance markers from inline edits to SKILL.md files.
Description check ✅ Passed The description clearly explains the rationale for removing provenance markers, details the replacement audit mechanism (commit subjects), specifies what markers are retained, notes the checklist update, and includes testing confirmation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Review rate limit: 8/10 reviews remaining, refill in 11 minutes and 35 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
skills/skill-evolution/SKILL.md (1)

152-152: Consider adding a checklist guard for commit-subject provenance.

Line 152 makes commit metadata the provenance source; adding a distillation-checklist item like “commit subject starts with skill-evolution:” would make this policy easier to apply consistently during reviews.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@skills/skill-evolution/SKILL.md` at line 152, Update the SKILL.md provenance
guidance (the paragraph that currently relies on commit metadata as the
provenance source) by adding a checklist guard item requiring a standardized
commit-subject prefix; specifically add a bullet like "commit subject starts
with `skill-evolution:`" to the existing checklist, place it alongside the other
distillation/checklist items for provenance, and match the file's current
checklist formatting and tone so reviewers see and enforce the rule
consistently.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@skills/skill-evolution/SKILL.md`:
- Line 152: Update the SKILL.md provenance guidance (the paragraph that
currently relies on commit metadata as the provenance source) by adding a
checklist guard item requiring a standardized commit-subject prefix;
specifically add a bullet like "commit subject starts with `skill-evolution:`"
to the existing checklist, place it alongside the other distillation/checklist
items for provenance, and match the file's current checklist formatting and tone
so reviewers see and enforce the rule consistently.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 5b0222c3-2ef6-44bb-919a-18783aa0b30c

📥 Commits

Reviewing files that changed from the base of the PR and between 9c48fba and 5f00c1f.

📒 Files selected for processing (1)
  • skills/skill-evolution/SKILL.md

@rgsl888prabhu rgsl888prabhu self-assigned this Apr 29, 2026
@rgsl888prabhu rgsl888prabhu added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Apr 29, 2026
@rgsl888prabhu
Copy link
Copy Markdown
Collaborator Author

/merge

@rapids-bot rapids-bot Bot merged commit 870d7e2 into NVIDIA:main Apr 30, 2026
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants