skill-evolution: drop inline provenance markers#1161
skill-evolution: drop inline provenance markers#1161rapids-bot[bot] merged 2 commits intoNVIDIA:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe provenance-tagging policy in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Review rate limit: 8/10 reviews remaining, refill in 11 minutes and 35 seconds. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
skills/skill-evolution/SKILL.md (1)
152-152: Consider adding a checklist guard for commit-subject provenance.Line 152 makes commit metadata the provenance source; adding a distillation-checklist item like “commit subject starts with
skill-evolution:” would make this policy easier to apply consistently during reviews.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@skills/skill-evolution/SKILL.md` at line 152, Update the SKILL.md provenance guidance (the paragraph that currently relies on commit metadata as the provenance source) by adding a checklist guard item requiring a standardized commit-subject prefix; specifically add a bullet like "commit subject starts with `skill-evolution:`" to the existing checklist, place it alongside the other distillation/checklist items for provenance, and match the file's current checklist formatting and tone so reviewers see and enforce the rule consistently.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@skills/skill-evolution/SKILL.md`:
- Line 152: Update the SKILL.md provenance guidance (the paragraph that
currently relies on commit metadata as the provenance source) by adding a
checklist guard item requiring a standardized commit-subject prefix;
specifically add a bullet like "commit subject starts with `skill-evolution:`"
to the existing checklist, place it alongside the other distillation/checklist
items for provenance, and match the file's current checklist formatting and tone
so reviewers see and enforce the rule consistently.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 5b0222c3-2ef6-44bb-919a-18783aa0b30c
📒 Files selected for processing (1)
skills/skill-evolution/SKILL.md
|
/merge |
Summary
Removes the
<!-- skill-evolution:start --> ... <!-- skill-evolution:end -->HTML-comment marker requirement for inline edits to existing SKILL.md files. The markers add visible noise that compounds across many small edits, whilegit log/git blamealready attribute every line to its origin commit. Audit trail now relies on a clear commit subject (e.g. "skill-evolution: add ... to lp-milp-formulation").Frontmatter
origin: skill-evolutionfor new skills and# origin: skill-evolutionheaders for code assets are kept — those edits are creating new files, not editing existing prose.Distillation checklist updated to remove the marker requirement.
Testing
./ci/utils/validate_skills.shpassesDocs