ci(nightly): set fail-fast: false on the build matrix#1186
Merged
rapids-bot[bot] merged 1 commit intoNVIDIA:mainfrom May 7, 2026
Merged
ci(nightly): set fail-fast: false on the build matrix#1186rapids-bot[bot] merged 1 commit intoNVIDIA:mainfrom
rapids-bot[bot] merged 1 commit intoNVIDIA:mainfrom
Conversation
Without fail-fast: false, a single failing matrix entry cancels every sibling. Today the release/26.06 entry 404s at the gh api branch lookup (the branch was bumped in NVIDIA#1091 on 2026-04-14 but the actual release/26.06 branch has not been cut from main yet), which cancels the otherwise-healthy main-branch dispatch and reports the whole nightly as failed. Setting fail-fast: false makes the two matrix entries independent: main keeps dispatching its nightly even when the release entry errors. The release entry will continue to fail until release/26.06 is cut (or the branch ref is reverted), but it no longer drags main down with it. Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
jameslamb
approved these changes
May 7, 2026
Collaborator
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the two matrix entries in
.github/workflows/nightly.yamlindependent so a missing release-branch ref no longer cancels the workingmain-branch nightly.Why this matters now: the matrix bumped to
release/26.06in #1091 on 2026-04-14, butrelease/26.06has not been cut frommainyet. Every nightly since has failed — the release entry 404s at thegh api .../branches/release/26.06lookup, the matrix's defaultfail-fast: truecancels the siblingmainentry, and the wrapper job reportsfailureeven though themaindispatch would have succeeded on its own.Fix: add
fail-fast: falseso each cuopt_branch dispatch runs independently.The release entry will still go red until
release/26.06is actually cut (or the line is reverted to a release branch that exists), but it no longer dragsmainwith it.Test plan
mainmatrix entry should dispatch and complete independent of therelease/26.06entry's outcome.Run workflowfrom Actions UI to verify both entries run to completion (or independent failure) before waiting for the cron.🤖 Generated with Claude Code