Skip to content

Fix MAJOR SonarQube bugs: mps_parser signed/unsigned compare and example init #1235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rgsl888prabhu wants to merge 2 commits into
base: main
Choose a base branch
from
+21 −13
Open

Fix MAJOR SonarQube bugs: mps_parser signed/unsigned compare and example init #1235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ee09c1
Fix two MAJOR SonarQube bugs: signed/unsigned compare and uninit exam…
rgsl888prabhu May 18, 2026
4f5ea40
Check malloc result before passing solution buffer to cuOpt API
rgsl888prabhu May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cpp/src/io/mps_parser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
#include <sstream>
#include <string>
#include <unordered_set>
#include <utility>

#ifdef MPS_PARSER_WITH_BZIP2
#include <bzlib.h>
Expand Down Expand Up @@ -634,7 +635,7 @@ std::vector<char> mps_parser_t<i_t, f_t>::file_to_string(const std::string& file
std::vector<char> buf(bufsize + 1);
rewind(fp.get());

mps_parser_expects(fread(buf.data(), sizeof(char), bufsize, fp.get()) == bufsize,
mps_parser_expects(std::cmp_equal(fread(buf.data(), sizeof(char), bufsize, fp.get()), bufsize),
error_type_t::ValidationError,
"Error reading MPS file! Given path: %s",
mps_file.c_str());
Expand Down
31 changes: 19 additions & 12 deletions docs/cuopt/source/cuopt-c/lp-qp-milp/examples/milp_mps_example.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,21 +119,28 @@ cuopt_int_t solve_mps_file(const char* filename)
termination_status_to_string(termination_status),
termination_status);
printf("Solve time: %f seconds\n", time);
printf("Objective value: %f\n", objective_value);

// Get and print solution variables
if (has_primal_solution) {
solution_values = (cuopt_float_t*)malloc(num_variables * sizeof(cuopt_float_t));
status = cuOptGetPrimalSolution(solution, solution_values);
if (status != CUOPT_SUCCESS) {
printf("Error getting solution values: %d\n", status);
goto DONE;
}
}
printf("Objective value: %f\n", objective_value);

// Get and print solution variables
solution_values =
(cuopt_float_t*)malloc((size_t)num_variables * sizeof(cuopt_float_t));
if (solution_values == NULL) {
printf("Error allocating solution buffer\n");
status = CUOPT_OUT_OF_MEMORY;
goto DONE;
}
status = cuOptGetPrimalSolution(solution, solution_values);
if (status != CUOPT_SUCCESS) {
printf("Error getting solution values: %d\n", status);
goto DONE;
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.

printf("\nSolution: \n");
for (cuopt_int_t i = 0; i < num_variables; i++) {
printf("x%d = %f\n", i + 1, solution_values[i]);
printf("\nSolution: \n");
for (cuopt_int_t i = 0; i < num_variables; i++) {
printf("x%d = %f\n", i + 1, solution_values[i]);
}
}

DONE:
Expand Down
Loading