ci: fix mangled python image tag on release/26.06#1269
Conversation
The release-prep substitution rewrote python:3.14-slim to python:26.06-slim in nightly-summary.yaml and build.yaml, which doesn't exist on Docker Hub. Restore the original tag matching main. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThis PR updates two CI workflow jobs to use the ChangesCI Python Runtime Updates & Release Script
🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
bdice
left a comment
There was a problem hiding this comment.
Please fix ci/release/update-version.sh in this PR. We may need to rerun that script as a part of manual forward-merges from release/26.06, so landing a fix for the script on release/26.06 is needed.
bdice
left a comment
There was a problem hiding this comment.
Meant to request changes for the above, accidentally hit wrong button
The image-tag substitution in update-version.sh matched any :N.N- pattern in workflow files, which rewrote python:3.14-slim to python:<RAPIDS>-slim during release prep (broke release/26.06 in PR NVIDIA#1269). Restrict the substitution to lines containing rapidsai/. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
The routing-example.ipynb file no longer exists, so the sed call errored every release-prep run. The faq.rst rewrite covers the documented main-branch-link case; nothing in the routing docs currently references the main branch. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
|
/merge |
fefc996
into
NVIDIA:release/26.06
Three fixes for the
release/26.06release-prep regression:1. Restore the python image tag —
nightly-summary.yaml:63andbuild.yaml:315hadpython:26.06-slim, which doesn't exist on Docker Hub. Reverted topython:3.14-slim(matchesmain). Unblocks the nightly-summary and build-summary jobs.2. Scope the version-bump regex —
ci/release/update-version.sh:142was matching any:N.N-in workflow files, which is what mangled the python image during release prep. Scoped to lines containingrapidsai/so unrelated images are left alone.3. Drop dead routing-example.ipynb sed call —
ci/release/update-version.shwas sed-ing a file that no longer exists, erroring on every release-prep run. The routing docs currently have nomain-branch links so the line was a no-op even before the file was removed.Verified by running
./ci/release/update-version.sh --run-context=release 99.99.00in a throwaway worktree — only the fourrapidsai/ci-conda:NN.NN-latestlines bump,python:3.14-slimis untouched, and no errors are emitted.Same regex bug exists on
main; this PR carries the fix onrelease/26.06so patch releases off this branch won't re-mangle. A separate cherry-pick tomainis straightforward.