Skip to content

ci: fix mangled python image tag on release/26.06#1269

Merged
rapids-bot[bot] merged 3 commits into
NVIDIA:release/26.06from
rgsl888prabhu:fix-python-image-tag
May 21, 2026
Merged

ci: fix mangled python image tag on release/26.06#1269
rapids-bot[bot] merged 3 commits into
NVIDIA:release/26.06from
rgsl888prabhu:fix-python-image-tag

Conversation

@rgsl888prabhu
Copy link
Copy Markdown
Collaborator

@rgsl888prabhu rgsl888prabhu commented May 21, 2026

Three fixes for the release/26.06 release-prep regression:

1. Restore the python image tagnightly-summary.yaml:63 and build.yaml:315 had python:26.06-slim, which doesn't exist on Docker Hub. Reverted to python:3.14-slim (matches main). Unblocks the nightly-summary and build-summary jobs.

2. Scope the version-bump regexci/release/update-version.sh:142 was matching any :N.N- in workflow files, which is what mangled the python image during release prep. Scoped to lines containing rapidsai/ so unrelated images are left alone.

3. Drop dead routing-example.ipynb sed callci/release/update-version.sh was sed-ing a file that no longer exists, erroring on every release-prep run. The routing docs currently have no main-branch links so the line was a no-op even before the file was removed.

Verified by running ./ci/release/update-version.sh --run-context=release 99.99.00 in a throwaway worktree — only the four rapidsai/ci-conda:NN.NN-latest lines bump, python:3.14-slim is untouched, and no errors are emitted.

Same regex bug exists on main; this PR carries the fix on release/26.06 so patch releases off this branch won't re-mangle. A separate cherry-pick to main is straightforward.

The release-prep substitution rewrote python:3.14-slim to
python:26.06-slim in nightly-summary.yaml and build.yaml, which
doesn't exist on Docker Hub. Restore the original tag matching main.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 21, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@rgsl888prabhu rgsl888prabhu self-assigned this May 21, 2026
@rgsl888prabhu rgsl888prabhu added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels May 21, 2026
@rgsl888prabhu rgsl888prabhu marked this pull request as ready for review May 21, 2026 15:26
@rgsl888prabhu rgsl888prabhu requested a review from a team as a code owner May 21, 2026 15:26
@rgsl888prabhu rgsl888prabhu requested a review from jameslamb May 21, 2026 15:26
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 21, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: aa517f78-e051-4e8e-9682-6a9eb80de66d

📥 Commits

Reviewing files that changed from the base of the PR and between e030f40 and 371edaf.

📒 Files selected for processing (1)
  • ci/release/update-version.sh
💤 Files with no reviewable changes (1)
  • ci/release/update-version.sh

📝 Walkthrough

Walkthrough

This PR updates two CI workflow jobs to use the python:3.14-slim container instead of python:26.06-slim, and scopes ci/release/update-version.sh’s image tag prefix rewrite to only affect rapidsai/ images and redirects a docs link rewrite to docs/cuopt/source/faq.rst.

Changes

CI Python Runtime Updates & Release Script

Layer / File(s) Summary
Python runtime container image updates
.github/workflows/build.yaml, .github/workflows/nightly-summary.yaml
The build-summary job (line 315) and nightly-summary job (line 63) container images are updated from python:26.06-slim to python:3.14-slim.
Release script: scope image tag rewrite & docs link target
ci/release/update-version.sh
The sed substitution that rewrites CI image tag prefixes is now scoped to lines containing rapidsai/, replacing tag prefixes with ${NEXT_SHORT_TAG}- only for rapidsai/ image references (lines ~141-143). In release run-context, the docs link rewrite target is changed to docs/cuopt/source/faq.rst (lines ~152-153).

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main fix: restoring the mangled Python image tag on the release/26.06 branch.
Description check ✅ Passed The description clearly explains all three fixes: Python image tag restoration, regex scoping, and removal of dead code, with verification details.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix ci/release/update-version.sh in this PR. We may need to rerun that script as a part of manual forward-merges from release/26.06, so landing a fix for the script on release/26.06 is needed.

Copy link
Copy Markdown
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meant to request changes for the above, accidentally hit wrong button

The image-tag substitution in update-version.sh matched any :N.N-
pattern in workflow files, which rewrote python:3.14-slim to
python:<RAPIDS>-slim during release prep (broke release/26.06 in
PR NVIDIA#1269). Restrict the substitution to lines containing rapidsai/.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
@rgsl888prabhu rgsl888prabhu requested a review from bdice May 21, 2026 16:00
The routing-example.ipynb file no longer exists, so the sed call
errored every release-prep run. The faq.rst rewrite covers the
documented main-branch-link case; nothing in the routing docs
currently references the main branch.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
@rgsl888prabhu
Copy link
Copy Markdown
Collaborator Author

/merge

@rapids-bot rapids-bot Bot merged commit fefc996 into NVIDIA:release/26.06 May 21, 2026
190 of 192 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants