skills(cuopt-developer): update for mathematical_optimization namespace refactor#1475
Conversation
…ce refactor Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ramakrishnap-nv
added
non-breaking
…es files Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
CI Test Summary✅ All 0 test job(s) passed. |
|
/nvskills-ci |
|
Caution Review failedFailed to post review comments. GitHub was unavailable or timed out while CodeRabbit was posting the review. Please request a new review later if the pull request still needs one. This happened while posting 1 inline comment. Use ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (4)
🧰 Additional context used📓 Path-based instructions (2)skills/**📄 CodeRabbit inference engine (CONTRIBUTING.md)
Files:
**⚙️ CodeRabbit configuration file
Files:
🪛 SkillSpector (2.2.3)skills/cuopt-developer/SKILL.md[warning] 73: [EA2] Autonomous Decision Making: Skill enables autonomous high-impact decisions without human-in-the-loop verification. Critical operations (destructive commands, financial transactions, data deletion) should require explicit user confirmation. Remediation: Add human-in-the-loop confirmation for destructive, irreversible, or high-impact operations. Never auto-execute commands that modify files, send data, or alter system state. (Excessive Agency (EA2)) [warning] 242: [PE2] Sudo/Root Execution: Commands invoke sudo or root privileges. Verify this elevated access is necessary and justified. Remediation: Avoid sudo/root unless strictly required. Prefer least-privilege patterns. If elevation is needed, document the justification and scope. (Privilege Escalation (PE2)) [warning] 36: [RA2] Session Persistence: Skill establishes unauthorized persistence across sessions via cron jobs, startup scripts, or state files. Session persistence allows an attacker to maintain access beyond the current interaction. Remediation: Remove any persistence mechanisms (cron jobs, startup scripts, state files). Skills should not maintain state across sessions without explicit user consent. (Rogue Agent (RA2)) [error] 38: [TM1] Tool Parameter Abuse: Tool parameters are crafted to achieve unintended or unsafe behavior. Parameter abuse can bypass intended safety checks (e.g. shell=True, --force, dangerous glob patterns). Remediation: Validate all tool parameters against an allowlist. Reject dangerous parameter values (shell=True, --force, -rf /) and use safe defaults. (Tool Misuse (TM1)) [error] 157: [TM1] Tool Parameter Abuse: Tool parameters are crafted to achieve unintended or unsafe behavior. Parameter abuse can bypass intended safety checks (e.g. shell=True, --force, dangerous glob patterns). Remediation: Validate all tool parameters against an allowlist. Reject dangerous parameter values (shell=True, --force, -rf /) and use safe defaults. (Tool Misuse (TM1)) [error] 171: [TM1] Tool Parameter Abuse: Tool parameters are crafted to achieve unintended or unsafe behavior. Parameter abuse can bypass intended safety checks (e.g. shell=True, --force, dangerous glob patterns). Remediation: Validate all tool parameters against an allowlist. Reject dangerous parameter values (shell=True, --force, -rf /) and use safe defaults. (Tool Misuse (TM1)) [error] 217: [TM1] Tool Parameter Abuse: Tool parameters are crafted to achieve unintended or unsafe behavior. Parameter abuse can bypass intended safety checks (e.g. shell=True, --force, dangerous glob patterns). Remediation: Validate all tool parameters against an allowlist. Reject dangerous parameter values (shell=True, --force, -rf /) and use safe defaults. (Tool Misuse (TM1)) [error] 39: [TM1] Tool Parameter Abuse: Tool parameters are crafted to achieve unintended or unsafe behavior. Parameter abuse can bypass intended safety checks (e.g. shell=True, --force, dangerous glob patterns). Remediation: Validate all tool parameters against an allowlist. Reject dangerous parameter values (shell=True, --force, -rf /) and use safe defaults. (Tool Misuse (TM1)) [error] 39: [TM1] Tool Parameter Abuse: Tool parameters are crafted to achieve unintended or unsafe behavior. Parameter abuse can bypass intended safety checks (e.g. shell=True, --force, dangerous glob patterns). Remediation: Validate all tool parameters against an allowlist. Reject dangerous parameter values (shell=True, --force, -rf /) and use safe defaults. (Tool Misuse (TM1)) 📝 WalkthroughWalkthroughThe cuOpt developer skill package was updated with revised documentation, refreshed benchmark values, and a replaced Sigstore bundle. One markdown file also gained a blank line. ChangescuOpt developer skill package
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/cuopt-developer/skill-card.md`:
- Around line 17-19: The skill card’s Requirements/Dependencies section leaves
the API key or external credential requirement ambiguous, while the credential
types already indicate none are needed. Update the Requirements / Dependencies
entry in the skill-card content to make the credential requirement explicit by
using a clear “No” value, and keep the existing credential type summary aligned
with that explicit statement.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: a7dbf797-c130-48b8-8d07-d222643d05ab
📒 Files selected for processing (4)
skills/cuopt-developer/BENCHMARK.mdskills/cuopt-developer/SKILL.mdskills/cuopt-developer/skill-card.mdskills/cuopt-developer/skill.oms.sig
| ## Requirements / Dependencies: <br> | ||
| **Requires API Key or External Credential:** [Not Specified] <br> | ||
| **Credential Type(s):** [None identified] <br> |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Make the credential requirement explicit.
Line 18 marks the requirement as unknown, but Line 19 already says no credential types were identified. Use an explicit No here so consumers do not treat the skill prerequisites as unresolved.
Suggested edit
-**Requires API Key or External Credential:** [Not Specified] <br>
+**Requires API Key or External Credential:** [No] <br>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ## Requirements / Dependencies: <br> | |
| **Requires API Key or External Credential:** [Not Specified] <br> | |
| **Credential Type(s):** [None identified] <br> | |
| ## Requirements / Dependencies: <br> | |
| **Requires API Key or External Credential:** [No] <br> | |
| **Credential Type(s):** [None identified] <br> |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@skills/cuopt-developer/skill-card.md` around lines 17 - 19, The skill card’s
Requirements/Dependencies section leaves the API key or external credential
requirement ambiguous, while the credential types already indicate none are
needed. Update the Requirements / Dependencies entry in the skill-card content
to make the credential requirement explicit by using a clear “No” value, and
keep the existing credential type summary aligned with that explicit statement.
|
/ok to test 3fd6775 |
2 participants
Update
cuopt-developerskill content for themathematical_optimizationnamespace refactor from #1446.Summary
NVSkills CI
Comment
/nvskills-cito trigger evaluation and signing.