remove 'cuda-python' dependency, test against oldest numba and numpy#1520
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
CI Test Summary✅ All 31 test job(s) passed. |
|
@ramakrishnap-nv or @tmckayus could you help investigate the CI failures? |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (8)
💤 Files with no reviewable changes (6)
📝 WalkthroughWalkthroughThis PR removes explicit ChangesDependency Pinning and CI Matrix Updates
Estimated code review effort: 2 (Simple) | ~10 minutes Related PRs: None identified. Suggested labels: dependencies, ci, conda Suggested reviewers: None identified.
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Think this is mostly stemming from xdist that I added recently, I have reverted it in this PR, please merge with main once this PR is merged #1519 |
|
Excellent looks like that fixed it, thanks @ramakrishnap-nv ! |
|
/merge |
Description
Contributes to rapidsai/build-planning#285
Removes this project's
cuda-pythondependency, which appears to be unnecessary:While doing that, also adds some use of the "test against oldest versions of dependencies" stuff originally set up in rapidsai/build-planning#81. That's used in a few RAPIDS repos and has been valuable in detecting when a floor needs to be bumped or compatibility workarounds need to be put in place. Proposing adding
numpyandnumba-cudathere for now.Checklist