Add support for cuda13 container and fix cuda13 lib issues in wheel #379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgsl888prabhu
requested review from
jakirkham,
jameslamb,
tmckayus and
vyasr
rgsl888prabhu
added
bug
jameslamb
requested changes
Sep 8, 2025
Collaborator
Author
Thought I had pushed, but some how missed it. Thank you for pointing it out @jameslamb . |
rgsl888prabhu
changed the title
tmckayus
approved these changes
Sep 8, 2025
5 tasks
jameslamb
approved these changes
Sep 8, 2025
Member
jameslamb
left a comment
jameslamb
left a comment
There was a problem hiding this comment.
Thanks for catching this today and prompting discussion that led me to learn a lot of things. I think several wheel workflows here could be simplified by switching to the cuda-toolkit metapackage.
Left some comments about that. Marking this "approve" just so you don't need to wait for another review from me to merge, but I hope you'll consider implementing those suggestions within this PR.
Collaborator
Author
|
/merge |
aliceb-nv
pushed a commit
that referenced
this pull request
Sep 22, 2025
…379) - This PR adds support for cuda 13 container for nightly and release - Also updates python version to 3.13 - Also cuda-toolkits have stopped using cu13 suffixes and they need to be fixed in dependencies - This also requires addition to RPATH since the paths are different for cu13 Authors: - Ramakrishnap (https://github.com/rgsl888prabhu) Approvers: - Trevor McKay (https://github.com/tmckayus) - James Lamb (https://github.com/jameslamb) URL: #379
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist